public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jon Masters <jonathan@jonmasters.org>
To: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>,
	Henry Ptasinski <henryp@broadcom.com>,
	Nohee Ko <noheek@broadcom.com>, Jon Masters <jcm@jonmasters.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: PROBLEM: brcm80211 hangs on 2.6.36-0.34.rc6.git3.fc15.x86_64
Date: Tue, 12 Oct 2010 03:47:39 -0400	[thread overview]
Message-ID: <1286869659.8574.10.camel@constitution.bos.jonmasters.org> (raw)
In-Reply-To: <1286538243.21485.298.camel@constitution.bos.jonmasters.org>

On Fri, 2010-10-08 at 07:44 -0400, Jon Masters wrote:
> On Fri, 2010-10-08 at 02:58 -0400, Jon Masters wrote:
> 
> > I tried building the new brcm80211 driver from staging-next on Fedora rawhide
> > kernel 2.6.36-0.34.rc6.git3.fc15.x86_64. Now, of course, it's not the
> > staging-next kernel (I'll try that now this doesn't work) but perhaps this
> > report will still be of use to the Broadcom/other wireless folks.
> 
> I pulled the latest staging-next onto Linus' latest git tree and still
> experience problems with the driver. It seems that the first attempt to
> actually transmit results in the system locking hard. Once again, I am
> attaching the output from running a netconsole (due to the box I'm on,
> it's an attachment this time, sorry about that - don't trust evolution)
> where the trace is basically the same as the original trace I posted.
> 
> NOTE: in both cases, the driver is loaded with "msglevel=2
> phymsglevel=2" which (although not documented) suggests to enable
> tracing, and does certainly yield more debugging output.

The problem may be that the driver doesn't correctly handle its logic in
wl_up in the case that the call to wlc_up doesn't result in the value of
wl->pub->up being TRUE. This can happen, for example if radio_disabled
is true, but I'm sure there are other problems, too. This result is not
properly checked in wl_up, so we can get a situation where we will later
try to call the ops->tx function with wl down. You also don't check
wl_up return codes in general, for example in wlc_radio_enable.

This might all be related to the rfkill and other soft switch stuff I'm
not really super up to date on. This laptop doesn't have a hardware
switch that I'm aware of, but I assume the state is somehow recorded in
software (by the BIOS?) and perhaps this is how rfkill is supposed to
work (I'll go look this up). Anyway, if I can figure out how to get the
radio to work and hack up the driver to start with the device down,
perhaps it'll not try to transmit and not fall over :)

Keep you posted.

Jon.



  parent reply	other threads:[~2010-10-12  7:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08  6:58 PROBLEM: brcm80211 hangs on 2.6.36-0.34.rc6.git3.fc15.x86_64 Jon Masters
2010-10-08 11:44 ` Jon Masters
2010-10-08 17:45   ` Brett Rudley
2010-10-11 20:12     ` Jon Masters
2010-10-11 21:01       ` Brett Rudley
2010-10-12  2:22         ` Jon Masters
2010-10-12  7:47   ` Jon Masters [this message]
2010-10-12  8:03     ` Jon Masters
2010-10-12  8:11       ` PROBLEM: brcm80211 hangs on 2.6.36-0.34.rc6.git3.fc15.x86_64 [FIXED] Jon Masters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1286869659.8574.10.camel@constitution.bos.jonmasters.org \
    --to=jonathan@jonmasters.org \
    --cc=brudley@broadcom.com \
    --cc=henryp@broadcom.com \
    --cc=jcm@jonmasters.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=noheek@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox