From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751429Ab0JLXDN (ORCPT ); Tue, 12 Oct 2010 19:03:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57365 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172Ab0JLXDL (ORCPT ); Tue, 12 Oct 2010 19:03:11 -0400 Subject: Re: [PATCH 2/5] secmark: make secmark object handling generic From: Eric Paris To: Paul Moore Cc: linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, jmorris@namei.org, selinux@tycho.nsa.gov, sds@tycho.nsa.gov, jengelh@medozas.de, linux-security-module@vger.kernel.org, mr.dash.four@googlemail.com, pablo@netfilter.org In-Reply-To: <1286924143.5133.86.camel@sifl> References: <20101012154008.26943.44399.stgit@paris.rdu.redhat.com> <20101012154015.26943.18385.stgit@paris.rdu.redhat.com> <1286924143.5133.86.camel@sifl> Content-Type: text/plain; charset="UTF-8" Date: Tue, 12 Oct 2010 19:01:52 -0400 Message-ID: <1286924512.2614.1.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2010-10-12 at 18:55 -0400, Paul Moore wrote: > On Tue, 2010-10-12 at 11:40 -0400, Eric Paris wrote: > > Right now secmark has lots of direct selinux calls. Use all LSM calls and > > remove all SELinux specific knowledge. The only SELinux specific knowledge > > we leave is the mode. The only point is to make sure that other LSMs at > > least test this generic code before they assume it works. (They may also > > have to make changes if they do not represent labels as strings) > > I'm sure you have, but I just want to make sure - you've tested this > change (and the others for that matter) against the existing iptables > userspace to make sure everything still works, right? I did. The only patch which needs userspace changes is the exporting of secctx over netlink. It appears the current userspace tools just ignores unknown field types. I have a patch to userspace to tell it about the new field and will send it after the kernel patch goes in. -Eric