From: Stanislav Brabec <sbrabec@suse.cz>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Greg KH <gregkh@suse.de>,
linux-kernel@vger.kernel.org, kyungmin.park@samsung.com,
Alan Cox <alan@linux.intel.com>, Arnd Bergmann <arnd@arndb.de>,
Andr Goddard Rosa <andre.goddard@gmail.com>,
Jason Wang <jason77.wang@gmail.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] Serial: BUGFIX: uart_resume_port has an omitted condition.
Date: Wed, 13 Oct 2010 13:26:45 +0200 [thread overview]
Message-ID: <1286969205.6082.700.camel@hammer.site> (raw)
In-Reply-To: <AANLkTimc-ETu4zrny=kmVRq8jnh2CDiVSqE-EXde4ioS@mail.gmail.com>
On Wed, 13 Oct 2010 15:38:13 +0900, MyungJoo Ham wrote:
> On Wed, Oct 13, 2010 at 3:26 PM, Greg KH <gregkh@suse.de> wrote:
> > On Wed, Oct 13, 2010 at 02:58:06PM +0900, MyungJoo Ham wrote:
> > Is this a regression? If so, from what working kernel? Or has this
> > always been this way?
>
> I don't think this is a regression to the previous version. Logically,
> it's matching the console_stop()-console_start() pair.
This disparity appeared deliberately in 4547be78. If you need
no_console_suspend and the hardware lets the device in an undefined
state after resume (i. e. PXA270), you need to call subset of the
resume, even if the suspend counterpart was not called. Yes, I can
imagine that it may be a source of problems.
Did you try the latest patches from Jason Wang from linux-serial list?
> Such hang in serial and its mitigation is observed in 2.6.36 at
> arch/arm/mach-s5pv310 machines. In these machines, it hanged with
> console_suspend_enabled == 0 every time.
It seems that support for no_console_suspend for all devices is becoming
more complicated. I guess that a new driver calls (maybe "save_state"
and "resume_state") or support for no_console_suspend directly in
drivers may be useful.
--
Best Regards / S pozdravem,
Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o. e-mail: sbrabec@suse.cz
Lihovarská 1060/12 tel: +420 284 028 966, +49 911 740538747
190 00 Praha 9 fax: +420 284 028 951
Czech Republic http://www.suse.cz/
next prev parent reply other threads:[~2010-10-13 11:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 5:58 [PATCH] Serial: BUGFIX: uart_resume_port has an omitted condition MyungJoo Ham
2010-10-13 6:26 ` Greg KH
2010-10-13 6:38 ` MyungJoo Ham
2010-10-13 11:26 ` Stanislav Brabec [this message]
2010-10-14 18:45 ` Greg KH
2010-10-14 19:45 ` Stanislav Brabec
2010-10-14 20:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286969205.6082.700.camel@hammer.site \
--to=sbrabec@suse.cz \
--cc=alan@linux.intel.com \
--cc=andre.goddard@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@suse.de \
--cc=jason77.wang@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox