From: Stanislav Brabec <sbrabec@suse.cz>
To: Greg KH <greg@kroah.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>, Greg KH <gregkh@suse.de>,
linux-kernel@vger.kernel.org, kyungmin.park@samsung.com,
Alan Cox <alan@linux.intel.com>, Arnd Bergmann <arnd@arndb.de>,
Andr Goddard Rosa <andre.goddard@gmail.com>,
Jason Wang <jason77.wang@gmail.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] Serial: BUGFIX: uart_resume_port has an omitted condition.
Date: Thu, 14 Oct 2010 21:45:57 +0200 [thread overview]
Message-ID: <1287085557.10610.18.camel@utx.lan> (raw)
In-Reply-To: <20101014184511.GA17096@kroah.com>
Greg KH wrote:
> > This disparity appeared deliberately in 4547be78. If you need
> > no_console_suspend and the hardware lets the device in an undefined
> > state after resume (i. e. PXA270), you need to call subset of the
> > resume, even if the suspend counterpart was not called. Yes, I can
> > imagine that it may be a source of problems.
> > It seems that support for no_console_suspend for all devices is becoming
> > more complicated. I guess that a new driver calls (maybe "save_state"
> > and "resume_state") or support for no_console_suspend directly in
> > drivers may be useful.
>
> Ok, so I'm guessing that this patch is not to be applied then, correct?
I just compared it with Jason Wang's patches. MyungJoo Ham's patch is
exactly equal to the PATCH 1/2. So it already has my ACK and it is
pending as:
serial-core: skip call set_termios/console_start when no_console_suspend
Related thread can be found in linux-serial archives from August 2010:
[PATCH RESEND 0/2] two serial_core suspend/resume fixes
To MyungJoo Ham: Could you verify, that Jason Wang's patch 2/2 does not
break your system? My patch to fix PXA270 does not exist yet. I'll ask
you in future for testing.
--
Best Regards / S pozdravem,
Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o. e-mail: sbrabec@suse.cz
Lihovarská 1060/12 tel: +420 284 028 966, +49 911 740538747
190 00 Praha 9 fax: +420 284 028 951
Czech Republic http://www.suse.cz/
next prev parent reply other threads:[~2010-10-14 19:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 5:58 [PATCH] Serial: BUGFIX: uart_resume_port has an omitted condition MyungJoo Ham
2010-10-13 6:26 ` Greg KH
2010-10-13 6:38 ` MyungJoo Ham
2010-10-13 11:26 ` Stanislav Brabec
2010-10-14 18:45 ` Greg KH
2010-10-14 19:45 ` Stanislav Brabec [this message]
2010-10-14 20:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287085557.10610.18.camel@utx.lan \
--to=sbrabec@suse.cz \
--cc=alan@linux.intel.com \
--cc=andre.goddard@gmail.com \
--cc=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=jason77.wang@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox