From: Peter Zijlstra <peterz@infradead.org>
To: Nikhil Rao <ncrao@google.com>
Cc: Ingo Molnar <mingo@elte.hu>, Mike Galbraith <efault@gmx.de>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Venkatesh Pallipadi <venki@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] sched: force balancing on newidle balance if local group has capacity
Date: Fri, 15 Oct 2010 14:06:35 +0200 [thread overview]
Message-ID: <1287144395.29097.1462.camel@twins> (raw)
In-Reply-To: <1286996978-7007-5-git-send-email-ncrao@google.com>
On Wed, 2010-10-13 at 12:09 -0700, Nikhil Rao wrote:
> +bool check_utilization(struct sd_lb_stats *sds)
> +{
> + if (!sds->this_has_capacity || sds->busiest_has_capacity)
> + return false;
> +
> + return true;
> +}
> +
> /******* find_busiest_group() helpers end here *********************/
>
> /**
> @@ -2824,6 +2845,10 @@ find_busiest_group(struct sched_domain *sd, int this_cpu,
> if (!sds.busiest || sds.busiest_nr_running == 0)
> goto out_balanced;
>
> + /* SD_BALANCE_NEWIDLE trumps SMP nice when underutilized */
> + if (idle == CPU_NEWLY_IDLE && check_utilization(&sds))
> + goto force_balance;
Is that really worth an extra function? Also the name isn't really
helpful, the comment suggests it should be called something like:
is_under_utilized().
Hmm?
next prev parent reply other threads:[~2010-10-15 12:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 19:09 [PATCH 0/4][RFC v2] Improve load balancing when tasks have large weight differential Nikhil Rao
2010-10-13 19:09 ` [PATCH 1/4] sched: do not consider SCHED_IDLE tasks to be cache hot Nikhil Rao
2010-10-13 19:09 ` [PATCH 2/4] sched: set group_imb only a task can be pulled from the busiest cpu Nikhil Rao
2010-10-18 19:23 ` [tip:sched/core] sched: Set " tip-bot for Nikhil Rao
2010-10-13 19:09 ` [PATCH 3/4] sched: drop group_capacity to 1 only if local group has extra capacity Nikhil Rao
2010-10-14 5:48 ` Nikhil Rao
2010-10-14 23:42 ` Suresh Siddha
2010-10-15 11:50 ` Peter Zijlstra
2010-10-15 16:13 ` Nikhil Rao
2010-10-15 17:05 ` Peter Zijlstra
2010-10-15 17:13 ` Suresh Siddha
2010-10-15 17:24 ` Peter Zijlstra
2010-10-15 17:27 ` Nikhil Rao
2010-10-13 19:09 ` [PATCH 4/4] sched: force balancing on newidle balance if local group has capacity Nikhil Rao
2010-10-15 12:06 ` Peter Zijlstra [this message]
2010-10-15 12:18 ` Mike Galbraith
2010-10-15 12:20 ` Peter Zijlstra
2010-10-15 12:35 ` Mike Galbraith
2010-10-15 16:19 ` Nikhil Rao
2010-10-15 12:08 ` Peter Zijlstra
2010-10-15 16:20 ` Nikhil Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287144395.29097.1462.camel@twins \
--to=peterz@infradead.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=ncrao@google.com \
--cc=suresh.b.siddha@intel.com \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox