From: Nikhil Rao <ncrao@google.com>
To: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Mike Galbraith <efault@gmx.de>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Venkatesh Pallipadi <venki@google.com>
Cc: linux-kernel@vger.kernel.org,
Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>,
Nikhil Rao <ncrao@google.com>
Subject: [PATCH 1/4] sched: do not consider SCHED_IDLE tasks to be cache hot
Date: Fri, 15 Oct 2010 13:12:27 -0700 [thread overview]
Message-ID: <1287173550-30365-2-git-send-email-ncrao@google.com> (raw)
In-Reply-To: <1287173550-30365-1-git-send-email-ncrao@google.com>
This patch adds a check in task_hot to return if the task has SCHED_IDLE
policy. SCHED_IDLE tasks have very low weight, and when run with regular
workloads, are typically scheduled many milliseconds apart. There is no
need to consider these tasks hot for load balancing.
Signed-off-by: Nikhil Rao <ncrao@google.com>
---
kernel/sched.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index dc85ceb..9e01848 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -2003,6 +2003,9 @@ task_hot(struct task_struct *p, u64 now, struct sched_domain *sd)
if (p->sched_class != &fair_sched_class)
return 0;
+ if (unlikely(p->policy == SCHED_IDLE))
+ return 0;
+
/*
* Buddy candidates are cache hot:
*/
--
1.7.1
next prev parent reply other threads:[~2010-10-15 20:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 20:12 [PATCH 0/4][RFC v3] Improve load balancing when tasks have large weight differential -v3 Nikhil Rao
2010-10-15 20:12 ` Nikhil Rao [this message]
2010-10-18 19:23 ` [tip:sched/core] sched: Do not consider SCHED_IDLE tasks to be cache hot tip-bot for Nikhil Rao
2010-10-15 20:12 ` [PATCH 2/4] sched: set group_imb only a task can be pulled from the busiest cpu Nikhil Rao
2010-10-15 20:12 ` [PATCH 3/4] sched: force balancing on newidle balance if local group has capacity Nikhil Rao
2010-10-18 19:23 ` [tip:sched/core] sched: Force " tip-bot for Nikhil Rao
2010-10-15 20:12 ` [PATCH 4/4] sched: drop group_capacity to 1 only if local group has extra capacity Nikhil Rao
2010-10-18 19:24 ` [tip:sched/core] sched: Drop " tip-bot for Nikhil Rao
2010-10-15 20:44 ` [PATCH 0/4][RFC v3] Improve load balancing when tasks have large weight differential -v3 Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2010-10-13 19:09 [PATCH 0/4][RFC v2] Improve load balancing when tasks have large weight differential Nikhil Rao
2010-10-13 19:09 ` [PATCH 1/4] sched: do not consider SCHED_IDLE tasks to be cache hot Nikhil Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287173550-30365-2-git-send-email-ncrao@google.com \
--to=ncrao@google.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=suresh.b.siddha@intel.com \
--cc=takeuchi_satoru@jp.fujitsu.com \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox