From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932394Ab0JQKiG (ORCPT <rfc822;w@1wt.eu>);
	Sun, 17 Oct 2010 06:38:06 -0400
Received: from casper.infradead.org ([85.118.1.10]:51764 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932281Ab0JQKiE convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 17 Oct 2010 06:38:04 -0400
Subject: Re: [PATCH] checkpatch: allow single space before labels
From: Peter Zijlstra <peterz@infradead.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
        linux-kernel@vger.kernel.org
In-Reply-To: <AANLkTin6H2AbL_Kr4XCtPOr+SQRxi0tKKF3puY4gybNu@mail.gmail.com>
References: <1287302737-3507-1-git-send-email-vapier@gentoo.org>
	 <1287303678.20968.37.camel@Joe-Laptop>
	 <AANLkTimmSRS3eVsW4EZUxnE_rfjeqmmgGnjtWbn3J_nY@mail.gmail.com>
	 <1287310889.1998.153.camel@laptop>
	 <AANLkTin6H2AbL_Kr4XCtPOr+SQRxi0tKKF3puY4gybNu@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Date: Sun, 17 Oct 2010 12:37:55 +0200
Message-ID: <1287311875.1998.156.camel@laptop>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.3 
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 2010-10-17 at 06:30 -0400, Mike Frysinger wrote:
> On Sun, Oct 17, 2010 at 06:21, Peter Zijlstra wrote:
> > On Sun, 2010-10-17 at 04:24 -0400, Mike Frysinger wrote:
> >> feel free to extend however as long as the end result is no warnings
> >> for " foo:" ;).
> >
> > I utterly detest those indented labels and am eradicating them wherever
> > I notice them. There's really no sane reason to use them what so ever.
> > Diff can be taught not to get confused about them, see my earlier email.
> 
> sure, with enough shell code thrown at a problem, you can do anything.
>  the change that started these warnings was for an unrelated check.
> no one proposed warning on indented labels, nor is there any statement
> at all in the coding style on these.
> 
> considering you highlighted the biggest reason (diff by default does
> not handle them properly), i think that invalidates against your "no
> sane reason" statement.

I think telling people to change their diff rules (--show-c-function
isn't default enabled either) is a lot better option than to uglify the
source. These indented labels are totally annoying when reading code.