From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757359Ab0JQOlk (ORCPT ); Sun, 17 Oct 2010 10:41:40 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:61194 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757347Ab0JQOli (ORCPT ); Sun, 17 Oct 2010 10:41:38 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=DPUF9VyNQYivMOeR1PDDl3elrDdi/XyLn4fEv6GCV7Bn62OY07e34cRHUdZ5gXdKCU J72cJLqto3vNZ8LyrLoO5d3LHcJMLXvm0Lww7ycpZRu1BfOzBLefHOo21wDRFhLNcIk5 wb2yzdrWJuXSgoYHK/mkp9FFCi5K1345Lq7Nw= From: Vasiliy Kulikov To: kernel-janitors@vger.kernel.org Cc: Greg Kroah-Hartman , Alan Cox , Jiri Slaby , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [PATCH 6/8] char: synclink: fix information leak to userland Date: Sun, 17 Oct 2010 18:41:32 +0400 Message-Id: <1287326493-8134-1-git-send-email-segooon@gmail.com> X-Mailer: git-send-email 1.7.0.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Structure new_line is copied to userland with some padding fields unitialized. It leads to leaking of stack memory. Signed-off-by: Vasiliy Kulikov --- Compile tested. drivers/char/synclink.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/char/synclink.c b/drivers/char/synclink.c index 3a6824f..abd0867 100644 --- a/drivers/char/synclink.c +++ b/drivers/char/synclink.c @@ -7846,6 +7846,8 @@ static int hdlcdev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) if (cmd != SIOCWANDEV) return hdlc_ioctl(dev, ifr, cmd); + memset(&new_line, 0, size); + switch(ifr->ifr_settings.type) { case IF_GET_IFACE: /* return current sync_serial_settings */ -- 1.7.0.4