From: Joe Perches <joe@perches.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Mike Frysinger <vapier@gentoo.org>,
Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: allow single space before labels
Date: Sun, 17 Oct 2010 09:54:58 -0700 [thread overview]
Message-ID: <1287334498.20968.53.camel@Joe-Laptop> (raw)
In-Reply-To: <1287310889.1998.153.camel@laptop>
On Sun, 2010-10-17 at 12:21 +0200, Peter Zijlstra wrote:
> On Sun, 2010-10-17 at 04:24 -0400, Mike Frysinger wrote:
> > feel free to extend however as long as the end result is no warnings
> > for " foo:" ;).
> I utterly detest those indented labels and am eradicating them wherever
> I notice them. There's really no sane reason to use them what so ever.
> Diff can be taught not to get confused about them, see my earlier email.
Your choice.
There are a half dozen or so in sched.c
There are 5000 or so single space indented labels.
There are 35000 or so labels without any indent.
His choice too no?
next prev parent reply other threads:[~2010-10-17 16:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-17 8:05 [PATCH] checkpatch: allow single space before labels Mike Frysinger
2010-10-17 8:21 ` Joe Perches
2010-10-17 8:24 ` Mike Frysinger
2010-10-17 10:21 ` Peter Zijlstra
2010-10-17 10:30 ` Mike Frysinger
2010-10-17 10:37 ` Peter Zijlstra
2010-10-17 10:52 ` Mike Frysinger
2010-10-17 16:54 ` Joe Perches [this message]
2010-10-17 19:30 ` Peter Zijlstra
2010-10-17 19:38 ` Joe Perches
2010-10-17 19:49 ` Peter Zijlstra
2010-10-17 19:49 ` Mike Frysinger
2010-10-17 20:01 ` Peter Zijlstra
2010-10-17 20:26 ` Mike Frysinger
2010-10-18 14:39 ` Ted Ts'o
2010-10-18 14:54 ` Ted Ts'o
2010-10-18 14:58 ` Peter Zijlstra
2010-10-18 15:03 ` Peter Zijlstra
2010-10-18 18:21 ` Mike Frysinger
2010-10-18 18:32 ` Peter Zijlstra
2010-10-18 19:09 ` Joe Perches
2010-10-17 10:20 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287334498.20968.53.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox