From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932716Ab0JQUCA (ORCPT ); Sun, 17 Oct 2010 16:02:00 -0400 Received: from canuck.infradead.org ([134.117.69.58]:43778 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932639Ab0JQUB7 convert rfc822-to-8bit (ORCPT ); Sun, 17 Oct 2010 16:01:59 -0400 Subject: Re: [PATCH] checkpatch: allow single space before labels From: Peter Zijlstra To: Mike Frysinger Cc: Joe Perches , Andy Whitcroft , linux-kernel@vger.kernel.org In-Reply-To: References: <1287302737-3507-1-git-send-email-vapier@gentoo.org> <1287303678.20968.37.camel@Joe-Laptop> <1287310889.1998.153.camel@laptop> <1287334498.20968.53.camel@Joe-Laptop> <1287343839.1998.699.camel@laptop> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Sun, 17 Oct 2010 22:01:50 +0200 Message-ID: <1287345710.1998.735.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2010-10-17 at 15:49 -0400, Mike Frysinger wrote: > sounds like a good reason to shut up the new unintended warnings I'm failing to see any logic there, old code doesn't generate warnings, its new code that would, and new code should never have any whitespace in front of labels.