From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754785Ab0JRKMX (ORCPT ); Mon, 18 Oct 2010 06:12:23 -0400 Received: from casper.infradead.org ([85.118.1.10]:33092 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754236Ab0JRKMW convert rfc822-to-8bit (ORCPT ); Mon, 18 Oct 2010 06:12:22 -0400 Subject: Re: [sparc build bug] Re: [tip:perf/core] irq: Add tracepoint to softirq_raise From: Peter Zijlstra To: Ingo Molnar Cc: Ingo Molnar , mathieu.desnoyers@efficios.com, sanagi.koki@jp.fujitsu.com, fweisbec@gmail.com, rostedt@goodmis.org, nhorman@tuxdriver.com, scott.a.mcmillan@intel.com, tglx@linutronix.de, laijs@cn.fujitsu.com, hpa@zytor.com, linux-kernel@vger.kernel.org, eric.dumazet@gmail.com, kaneshige.kenji@jp.fujitsu.com, davem@davemloft.net, izumi.taku@jp.fujitsu.com, kosaki.motohiro@jp.fujitsu.com, linux-tip-commits@vger.kernel.org, Heiko Carstens In-Reply-To: <1287395077.29097.1543.camel@twins> References: <4C724298.4050509@jp.fujitsu.com> <20100908112529.GA25931@elte.hu> <1287395077.29097.1543.camel@twins> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Mon, 18 Oct 2010 12:11:47 +0200 Message-ID: <1287396707.29097.1544.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2010-10-18 at 11:44 +0200, Peter Zijlstra wrote: > On Wed, 2010-09-08 at 13:25 +0200, Ingo Molnar wrote: > > * tip-bot for Lai Jiangshan wrote: > > > > > Commit-ID: 2bf2160d8805de64308e2e7c3cd97813cb58ed2f > > > Gitweb: http://git.kernel.org/tip/2bf2160d8805de64308e2e7c3cd97813cb58ed2f > > > Author: Lai Jiangshan > > > AuthorDate: Mon, 23 Aug 2010 18:42:48 +0900 > > > Committer: Frederic Weisbecker > > > CommitDate: Tue, 7 Sep 2010 17:49:34 +0200 > > > > > > irq: Add tracepoint to softirq_raise > > > > > > Add a tracepoint for tracing when softirq action is raised. > > > > > > This and the existing tracepoints complete softirq's tracepoints: > > > softirq_raise, softirq_entry and softirq_exit. > > > > > > And when this tracepoint is used in combination with > > > the softirq_entry tracepoint we can determine > > > the softirq raise latency. > > > > > > Signed-off-by: Lai Jiangshan > > > Acked-by: Mathieu Desnoyers > > > Acked-by: Neil Horman > > > Cc: David Miller > > > Cc: Kaneshige Kenji > > > Cc: Izumo Taku > > > Cc: Kosaki Motohiro > > > Cc: Lai Jiangshan > > > Cc: Scott Mcmillan > > > Cc: Steven Rostedt > > > Cc: Eric Dumazet > > > LKML-Reference: <4C724298.4050509@jp.fujitsu.com> > > > [ factorize softirq events with DECLARE_EVENT_CLASS ] > > > Signed-off-by: Koki Sanagi > > > Signed-off-by: Frederic Weisbecker > > > --- > > > include/linux/interrupt.h | 8 +++++++- > > > include/trace/events/irq.h | 26 ++++++++++++++++++++++++-- > > > 2 files changed, 31 insertions(+), 3 deletions(-) > > > I could build sparc64_defconfig, but s390 is broken for me by this... the below makes s390 build again, not sure its completely safe for all configs though... Heiko? --- arch/s390/include/asm/hardirq.h | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/s390/include/asm/hardirq.h b/arch/s390/include/asm/hardirq.h index 498bc38..9558a71 100644 --- a/arch/s390/include/asm/hardirq.h +++ b/arch/s390/include/asm/hardirq.h @@ -15,7 +15,6 @@ #include #include #include -#include #include #define local_softirq_pending() (S390_lowcore.softirq_pending)