From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755911Ab0JRNzA (ORCPT ); Mon, 18 Oct 2010 09:55:00 -0400 Received: from mail.bugwerft.de ([212.112.241.193]:50584 "EHLO mail.bugwerft.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755803Ab0JRNy7 (ORCPT ); Mon, 18 Oct 2010 09:54:59 -0400 X-Greylist: delayed 554 seconds by postgrey-1.27 at vger.kernel.org; Mon, 18 Oct 2010 09:54:58 EDT From: Daniel Mack To: linux-kernel@vger.kernel.org Cc: s.neumann@raumfeld.com, linux-input@vger.kernel.org, Daniel Mack , Dmitry Torokhov Subject: [PATCH 2/2] input: fix EVIOCSABS regression Date: Mon, 18 Oct 2010 15:45:24 +0200 Message-Id: <1287409524-3032-2-git-send-email-zonque@gmail.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1287409524-3032-1-git-send-email-zonque@gmail.com> References: <1287409524-3032-1-git-send-email-zonque@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 448cd16 ("Input: evdev - rearrange ioctl handling") broke EVIOCSABS by checking for the wrong direction bit. Signed-off-by: Daniel Mack Reported-by: Sven Neumann Tested-by: Sven Neumann Cc: Dmitry Torokhov --- drivers/input/evdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c index afb64cf..9ddafc3 100644 --- a/drivers/input/evdev.c +++ b/drivers/input/evdev.c @@ -683,7 +683,7 @@ static long evdev_do_ioctl(struct file *file, unsigned int cmd, } } - if (_IOC_DIR(cmd) == _IOC_READ) { + if (_IOC_DIR(cmd) == _IOC_WRITE) { if ((_IOC_NR(cmd) & ~ABS_MAX) == _IOC_NR(EVIOCSABS(0))) { -- 1.7.1