From: Peter Zijlstra <peterz@infradead.org>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: Mike Frysinger <vapier@gentoo.org>, Joe Perches <joe@perches.com>,
Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: allow single space before labels
Date: Mon, 18 Oct 2010 16:58:53 +0200 [thread overview]
Message-ID: <1287413933.29097.1608.camel@twins> (raw)
In-Reply-To: <20101018145400.GD4120@thunk.org>
On Mon, 2010-10-18 at 10:54 -0400, Ted Ts'o wrote:
> Note that there is absolutely nothing about how labels should be
> indented in CodingStyle at all, and I very much resist code
> straightjackets being imposed by checkpatch.pl implementors.
>
> Can we please stop this nonsense?
1) ignoring checkpatch over taste is good
2) by 1) its impossible to get checkpatch right
3) therefore pure checkpatch patches are nonsense
So can we agree that checkpatch is ok in its current form, and we should
simply administer physical violence towards checkpatch wankers?
PS. I frequently practise 2).
PPS. I find your preferred label indenting truly hideous.
next prev parent reply other threads:[~2010-10-18 14:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-17 8:05 [PATCH] checkpatch: allow single space before labels Mike Frysinger
2010-10-17 8:21 ` Joe Perches
2010-10-17 8:24 ` Mike Frysinger
2010-10-17 10:21 ` Peter Zijlstra
2010-10-17 10:30 ` Mike Frysinger
2010-10-17 10:37 ` Peter Zijlstra
2010-10-17 10:52 ` Mike Frysinger
2010-10-17 16:54 ` Joe Perches
2010-10-17 19:30 ` Peter Zijlstra
2010-10-17 19:38 ` Joe Perches
2010-10-17 19:49 ` Peter Zijlstra
2010-10-17 19:49 ` Mike Frysinger
2010-10-17 20:01 ` Peter Zijlstra
2010-10-17 20:26 ` Mike Frysinger
2010-10-18 14:39 ` Ted Ts'o
2010-10-18 14:54 ` Ted Ts'o
2010-10-18 14:58 ` Peter Zijlstra [this message]
2010-10-18 15:03 ` Peter Zijlstra
2010-10-18 18:21 ` Mike Frysinger
2010-10-18 18:32 ` Peter Zijlstra
2010-10-18 19:09 ` Joe Perches
2010-10-17 10:20 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287413933.29097.1608.camel@twins \
--to=peterz@infradead.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox