Re: [PATCH v3 09/11] memcg: add cgroupfs interface to memcg dirty limits

KAMEZAWA Hiroyuki
2010-10-20T03:50:19Z

On Wed, 20 Oct 2010 12:31:10 +0900
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:

> On Mon, 18 Oct 2010 17:39:42 -0700
> Greg Thelen <gthelen@google.com> wrote:
>
> > Add cgroupfs interface to memcg dirty page limits:
> > Direct write-out is controlled with:
> > - memory.dirty_ratio
> > - memory.dirty_limit_in_bytes
> >
> > Background write-out is controlled with:
> > - memory.dirty_background_ratio
> > - memory.dirty_background_limit_bytes
> >
> > Other memcg cgroupfs files support 'M', 'm', 'k', 'K', 'g'
> > and 'G' suffixes for byte counts. This patch provides the
> > same functionality for memory.dirty_limit_in_bytes and
> > memory.dirty_background_limit_bytes.
> >
> > Signed-off-by: Andrea Righi <arighi@develer.com>
> > Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
> > Signed-off-by: Greg Thelen <gthelen@google.com>
>
> Acked-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
>
> One question: shouldn't we return -EINVAL when writing to dirty(_background)_limit_bytes
> a bigger value than that of global one(if any)

This should be checked. I'm now writing one add-on.

> ? Or do you intentionally
> set the input value without comparing it with the global value ?

please see my patch sent(memcg+dirtylimit] Fix overwriting global vm dirty limit setting by memcg)

IMHO, check at setting value is not helpful because global value can be changed
after we set this. My patch checks it at calculating dirtyable bytes.

> But, hmm..., IMHO we should check it in __mem_cgroup_dirty_param() or something
> not to allow dirty pages more than global limit.
>
yes.

Thanks,
-Kame