public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mfd: Fix ezx_pcap_probe error path
@ 2010-10-19 12:28 Axel Lin
  2010-10-19 13:02 ` Samuel Ortiz
  0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2010-10-19 12:28 UTC (permalink / raw)
  To: linux-kernel; +Cc: Samuel Ortiz, Harald Welte, Daniel Ribeiro

return -ENOMEM if create_singlethread_workqueue failed.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/mfd/ezx-pcap.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c
index d283d77..c2b698d 100644
--- a/drivers/mfd/ezx-pcap.c
+++ b/drivers/mfd/ezx-pcap.c
@@ -465,6 +465,7 @@ static int __devinit ezx_pcap_probe(struct spi_device *spi)
 	pcap->irq_base = pdata->irq_base;
 	pcap->workqueue = create_singlethread_workqueue("pcapd");
 	if (!pcap->workqueue) {
+		ret = -ENOMEM;
 		dev_err(&spi->dev, "cant create pcap thread\n");
 		goto free_pcap;
 	}
-- 
1.7.0.4




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mfd: Fix ezx_pcap_probe error path
  2010-10-19 12:28 [PATCH] mfd: Fix ezx_pcap_probe error path Axel Lin
@ 2010-10-19 13:02 ` Samuel Ortiz
  0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2010-10-19 13:02 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Harald Welte, Daniel Ribeiro

Hi Axel,

On Tue, Oct 19, 2010 at 08:28:24PM +0800, Axel Lin wrote:
> return -ENOMEM if create_singlethread_workqueue failed.
Thanks for the patch, applied to my for-next branch.

Cheers,
Samuel.


> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
>  drivers/mfd/ezx-pcap.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c
> index d283d77..c2b698d 100644
> --- a/drivers/mfd/ezx-pcap.c
> +++ b/drivers/mfd/ezx-pcap.c
> @@ -465,6 +465,7 @@ static int __devinit ezx_pcap_probe(struct spi_device *spi)
>  	pcap->irq_base = pdata->irq_base;
>  	pcap->workqueue = create_singlethread_workqueue("pcapd");
>  	if (!pcap->workqueue) {
> +		ret = -ENOMEM;
>  		dev_err(&spi->dev, "cant create pcap thread\n");
>  		goto free_pcap;
>  	}
> -- 
> 1.7.0.4
> 
> 
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-10-19 13:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-19 12:28 [PATCH] mfd: Fix ezx_pcap_probe error path Axel Lin
2010-10-19 13:02 ` Samuel Ortiz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox