From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Tony Lindgren <tony@atomide.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP2+: fix missing variable declaration
Date: Wed, 23 Aug 2017 16:53:50 +0300 [thread overview]
Message-ID: <12875092.dy1RW0XmqV@avalon> (raw)
In-Reply-To: <20170823132841.642239-1-arnd@arndb.de>
Hi Arnd,
On Wednesday, 23 August 2017 16:28:19 EEST Arnd Bergmann wrote:
> The function that was added doesn't actually build:
>
> arch/arm/mach-omap2/display.c: In function 'omapdss_init_fbdev':
> arch/arm/mach-omap2/display.c:184:2: error: 'r' undeclared (first use in
> this function)
>
> This adds a declaration for 'r' to fix it.
>
> Fixes: 5ce783025c82 ("ARM: OMAP2+: Don't register omapdss device for
> omapdrm")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looks like I haven't tested the patch with CONFIG_FB_OMAP2 enabled after the
last rebase. I'm very sorry about that :-(
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tomi, I assume you will pick this up and sent it to Dave for v4.14-rc1.
> ---
> arch/arm/mach-omap2/display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c
> index 798fc718fffe..b3f6eb5d04a2 100644
> --- a/arch/arm/mach-omap2/display.c
> +++ b/arch/arm/mach-omap2/display.c
> @@ -172,6 +172,7 @@ static int __init omapdss_init_fbdev(void)
> .set_min_bus_tput = omap_dss_set_min_bus_tput,
> };
> struct device_node *node;
> + int r;
>
> board_data.version = omap_display_get_version();
> if (board_data.version == OMAPDSS_VER_UNKNOWN) {
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-08-23 13:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 13:28 [PATCH] ARM: OMAP2+: fix missing variable declaration Arnd Bergmann
2017-08-23 13:53 ` Laurent Pinchart [this message]
2017-08-23 14:53 ` Tony Lindgren
2017-08-24 12:18 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12875092.dy1RW0XmqV@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox