Re: [tip:perf/core] x86, NMI: Rewrite NMI handler

Peter Zijlstra
2010-10-16T17:29:33Z

On Sat, 2010-10-16 at 16:36 +0000, tip-bot for Huang Ying wrote:
> Commit-ID: e21f3e4957f4a55f546873605a5caa59556bb144
> Gitweb: http://git.kernel.org/tip/e21f3e4957f4a55f546873605a5caa59556bb144
> Author: Huang Ying <ying.huang@intel.com>
> AuthorDate: Fri, 15 Oct 2010 22:22:16 -0400
> Committer: Ingo Molnar <mingo@elte.hu>
> CommitDate: Sat, 16 Oct 2010 15:01:27 +0200
>
> x86, NMI: Rewrite NMI handler
>
> The original NMI handler is quite outdated in many aspects. This
> patch tries to fix it.
>
> The order to process the NMI sources are changed as follow:
>
> notify_die(DIE_NMI_IPI);
> notify_die(DIE_NMI);
> /* process io port 0x61 */
> nmi_watchdog_touch();
> unknown_nmi();

NACK!

I object to the DIE_NMI_IPI existance..