Re: [PATCH 5/5] x86, NMI: Remove do_nmi_callback logic

Robert Richter
2010-10-19T15:03:54Z

On 15.10.10 22:22:18, Don Zickus wrote:
> From: Huang Ying <ying.huang@intel.com>
>
> do_nmi_callback related logic is removed, because it is useless, just
> adds code complexity.
>
> unknown_nmi_panic sysctl is reserved to keep kernel ABI unchanged.
>
> Signed-off-by: Huang Ying <ying.huang@intel.com>
> Signed-off-by: Don Zickus <dzickus@redhat.com>
> ---
> arch/x86/include/asm/nmi.h | 10 +++++++++-
> arch/x86/kernel/apic/hw_nmi.c | 1 -
> arch/x86/kernel/apic/nmi.c | 29 +----------------------------
> arch/x86/kernel/traps.c | 17 +++++++++++------
> 4 files changed, 21 insertions(+), 36 deletions(-)

> diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
> index accb2f4..9ef8e15 100644
> --- a/arch/x86/kernel/traps.c
> +++ b/arch/x86/kernel/traps.c
> @@ -83,6 +83,8 @@ EXPORT_SYMBOL_GPL(used_vectors);
>
> static int ignore_nmis;
>
> +int unknown_nmi_panic;

I didn't apply the patches, so I am not really sure, but I think this
could be static now.

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center