* [PATCH] mfd: Fix resource reclaim in pcf50633_remove()
@ 2010-10-20 8:56 Axel Lin
2010-10-20 9:11 ` Harald Welte
2010-10-21 22:54 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2010-10-20 8:56 UTC (permalink / raw)
To: linux-kernel; +Cc: Samuel Ortiz, Harald Welte
Calling sysfs_remove_group() to remove sysfs entries
and unregister bl_pdev in pcf50633_remove().
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/mfd/pcf50633-core.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
index 6d4233f..501ce13 100644
--- a/drivers/mfd/pcf50633-core.c
+++ b/drivers/mfd/pcf50633-core.c
@@ -339,12 +339,14 @@ static int __devexit pcf50633_remove(struct i2c_client *client)
struct pcf50633 *pcf = i2c_get_clientdata(client);
int i;
+ sysfs_remove_group(&client->dev.kobj, &pcf_attr_group);
pcf50633_irq_free(pcf);
platform_device_unregister(pcf->input_pdev);
platform_device_unregister(pcf->rtc_pdev);
platform_device_unregister(pcf->mbc_pdev);
platform_device_unregister(pcf->adc_pdev);
+ platform_device_unregister(pcf->bl_pdev);
for (i = 0; i < PCF50633_NUM_REGULATORS; i++)
platform_device_unregister(pcf->regulator_pdev[i]);
--
1.7.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: Fix resource reclaim in pcf50633_remove()
2010-10-20 8:56 [PATCH] mfd: Fix resource reclaim in pcf50633_remove() Axel Lin
@ 2010-10-20 9:11 ` Harald Welte
2010-10-21 22:54 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Harald Welte @ 2010-10-20 9:11 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Samuel Ortiz
Acked-by: Harald Welte <laforge@gnumonks.org>
On Wed, Oct 20, 2010 at 04:56:59PM +0800, Axel Lin wrote:
> Calling sysfs_remove_group() to remove sysfs entries
> and unregister bl_pdev in pcf50633_remove().
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/mfd/pcf50633-core.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
> index 6d4233f..501ce13 100644
> --- a/drivers/mfd/pcf50633-core.c
> +++ b/drivers/mfd/pcf50633-core.c
> @@ -339,12 +339,14 @@ static int __devexit pcf50633_remove(struct i2c_client *client)
> struct pcf50633 *pcf = i2c_get_clientdata(client);
> int i;
>
> + sysfs_remove_group(&client->dev.kobj, &pcf_attr_group);
> pcf50633_irq_free(pcf);
>
> platform_device_unregister(pcf->input_pdev);
> platform_device_unregister(pcf->rtc_pdev);
> platform_device_unregister(pcf->mbc_pdev);
> platform_device_unregister(pcf->adc_pdev);
> + platform_device_unregister(pcf->bl_pdev);
>
> for (i = 0; i < PCF50633_NUM_REGULATORS; i++)
> platform_device_unregister(pcf->regulator_pdev[i]);
> --
> 1.7.2
>
>
>
--
- Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: Fix resource reclaim in pcf50633_remove()
2010-10-20 8:56 [PATCH] mfd: Fix resource reclaim in pcf50633_remove() Axel Lin
2010-10-20 9:11 ` Harald Welte
@ 2010-10-21 22:54 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2010-10-21 22:54 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Harald Welte
Hi Axel,
On Wed, Oct 20, 2010 at 04:56:59PM +0800, Axel Lin wrote:
> Calling sysfs_remove_group() to remove sysfs entries
> and unregister bl_pdev in pcf50633_remove().
patch applied, thanks.
Cheers,
Samuel.
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/mfd/pcf50633-core.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
> index 6d4233f..501ce13 100644
> --- a/drivers/mfd/pcf50633-core.c
> +++ b/drivers/mfd/pcf50633-core.c
> @@ -339,12 +339,14 @@ static int __devexit pcf50633_remove(struct i2c_client *client)
> struct pcf50633 *pcf = i2c_get_clientdata(client);
> int i;
>
> + sysfs_remove_group(&client->dev.kobj, &pcf_attr_group);
> pcf50633_irq_free(pcf);
>
> platform_device_unregister(pcf->input_pdev);
> platform_device_unregister(pcf->rtc_pdev);
> platform_device_unregister(pcf->mbc_pdev);
> platform_device_unregister(pcf->adc_pdev);
> + platform_device_unregister(pcf->bl_pdev);
>
> for (i = 0; i < PCF50633_NUM_REGULATORS; i++)
> platform_device_unregister(pcf->regulator_pdev[i]);
> --
> 1.7.2
>
>
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-21 22:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-20 8:56 [PATCH] mfd: Fix resource reclaim in pcf50633_remove() Axel Lin
2010-10-20 9:11 ` Harald Welte
2010-10-21 22:54 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox