From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752371Ab0JTLqL (ORCPT <rfc822;w@1wt.eu>);
	Wed, 20 Oct 2010 07:46:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44590 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751327Ab0JTLqJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 20 Oct 2010 07:46:09 -0400
Subject: Re: linux-next: build failure after merge of the final tree
 (security-testing tree related)
From: Eric Paris <eparis@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: James Morris <jmorris@namei.org>, linux-next@vger.kernel.org,
        linux-kernel@vger.kernel.org
In-Reply-To: <20101020161024.af794b4a.sfr@canb.auug.org.au>
References: <20101020161024.af794b4a.sfr@canb.auug.org.au>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 20 Oct 2010 07:46:02 -0400
Message-ID: <1287575162.2530.285.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2010-10-20 at 16:10 +1100, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> security/selinux/ss/services.c: In function 'security_read_policy':
> security/selinux/ss/services.c:3172: error: implicit declaration of function 'vmalloc_user'
> security/selinux/ss/services.c:3172: warning: assignment makes pointer from integer without a cast
> 
> Caused by commit ed167abda544bb7f8cf09dc3d3608c79e1cfb25f ("SELinux:
> allow userspace to read policy back out of the kernel") and
> bb17427490e1e295f3c0550c308684bd952a585d ("selinux: implement mmap
> on /selinux/policy").
> 
> Please see Rule 1 (in Documentation/SubmitChecklist).
> 
> I applied the following patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 20 Oct 2010 16:08:00 +1100
> Subject: [PATCH] selinux: include vmalloc.h for vmalloc_user

Huh, not sure why it builds cleanly here.  I'm applying my patch series
on top of linux-next from the 18th.  In any case this looks correct.

Acked-by: Eric Paris <eparis@redhat.com>

> 
> ---
>  security/selinux/ss/services.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
> index 3a1739b..223c1ff 100644
> --- a/security/selinux/ss/services.c
> +++ b/security/selinux/ss/services.c
> @@ -51,6 +51,7 @@
>  #include <linux/mutex.h>
>  #include <linux/selinux.h>
>  #include <linux/flex_array.h>
> +#include <linux/vmalloc.h>
>  #include <net/netlabel.h>
>  
>  #include "flask.h"
> -- 
> 1.7.1
>