From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, paulus@samba.org,
davem@davemloft.net, fweisbec@gmail.com,
perfmon2-devel@lists.sf.net, eranian@gmail.com,
robert.richter@amd.com
Subject: Re: [PATCH] perf_events: fix time tracking in samples
Date: Wed, 20 Oct 2010 15:04:39 +0200 [thread overview]
Message-ID: <1287579879.3488.14.camel@twins> (raw)
In-Reply-To: <AANLkTimtD249SMg3DeyOX3BFpHCtZeq8cU-2g_m-5GKV@mail.gmail.com>
On Wed, 2010-10-20 at 14:42 +0200, Stephane Eranian wrote:
> It may be better to try another approach just for PERF_SAMPLE_READ
> with its own version of ctx->time. What about if on event_sched_in() you
> were snapshotting ctx->time. Then in the perf_output_read_event(), you'd
> have to compute the time delta and add it to this private version of
> ctx->time and store that in the sample.
Right, that might work.
prev parent reply other threads:[~2010-10-20 13:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 16:47 [PATCH] perf_events: fix time tracking in samples Stephane Eranian
2010-10-19 16:52 ` Peter Zijlstra
2010-10-19 17:01 ` Stephane Eranian
2010-10-19 17:09 ` Peter Zijlstra
2010-10-19 19:03 ` Stephane Eranian
2010-10-20 11:00 ` Peter Zijlstra
2010-10-20 11:13 ` Peter Zijlstra
2010-10-20 12:42 ` Stephane Eranian
2010-10-20 13:04 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287579879.3488.14.camel@twins \
--to=peterz@infradead.org \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox