From: Davidlohr Bueso <dave@gnu.org>
To: rpurdie@rpsys.net
Cc: raph@8d.com, tpiepho@freescale.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio led: properly initialize return value
Date: Thu, 21 Oct 2010 18:21:14 -0300 [thread overview]
Message-ID: <1287696074.2075.4.camel@cowboy> (raw)
In-Reply-To: <1287417219.4214.5.camel@cowboy>
On Mon, 2010-10-18 at 12:53 -0300, Davidlohr Bueso wrote:
> gpio led: properly initialize return value in gpio_led_init()
>
> In the event that none of the configs are set (CONFIG_LEDS_GPIO_PLATFORM, CONFIG_LEDS_GPIO_OF,
> CONFIG_LEDS_GPIO_PLATFORM), we will return bogus when initializing the module.
>
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> ---
> drivers/leds/leds-gpio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
> index ea57e05..4d9fa38 100644
> --- a/drivers/leds/leds-gpio.c
> +++ b/drivers/leds/leds-gpio.c
> @@ -316,7 +316,7 @@ static struct of_platform_driver of_gpio_leds_driver = {
>
> static int __init gpio_led_init(void)
> {
> - int ret;
> + int ret = 0;
>
> #ifdef CONFIG_LEDS_GPIO_PLATFORM
> ret = platform_driver_register(&gpio_led_driver);
prev parent reply other threads:[~2010-10-21 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 15:53 [PATCH] gpio led: properly initialize return value Davidlohr Bueso
2010-10-21 21:21 ` Davidlohr Bueso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287696074.2075.4.camel@cowboy \
--to=dave@gnu.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raph@8d.com \
--cc=rpurdie@rpsys.net \
--cc=tpiepho@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox