* [PATCH 1/3] sparc: don't #include asm/system.h in asm/jump_label.h
@ 2010-10-25 15:52 Namhyung Kim
2010-10-25 15:52 ` [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF_EVENTS option Namhyung Kim
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Namhyung Kim @ 2010-10-25 15:52 UTC (permalink / raw)
To: David S. Miller; +Cc: sparclinux, linux-kernel
It seems that #include <asm/system.h> makes a circular dependency
between kernel.h and bitmap.h which breaks allmodconfig build.
Removing the line makes no change because jump_label.h doesn't
need it actually AFAICS. Compile tested on sparc32 allmodconfig.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
Failed build log is as following:
CC arch/sparc/kernel/asm-offsets.s
In file included from include/linux/cpumask.h:11:0,
from arch/sparc/include/asm/smp_32.h:15,
from arch/sparc/include/asm/smp.h:6,
from arch/sparc/include/asm/system_32.h:12,
from arch/sparc/include/asm/system.h:6,
from arch/sparc/include/asm/jump_label.h:7,
from include/linux/jump_label.h:5,
from include/linux/dynamic_debug.h:4,
from include/linux/kernel.h:20,
from include/linux/sched.h:54,
from arch/sparc/kernel/asm-offsets.c:13:
include/linux/bitmap.h: In function 'bitmap_zero':
include/linux/bitmap.h:159:3: error: implicit declaration of function 'DIV_ROUND_UP'
In file included from arch/sparc/include/asm/smp_32.h:15:0,
from arch/sparc/include/asm/smp.h:6,
from arch/sparc/include/asm/system_32.h:12,
from arch/sparc/include/asm/system.h:6,
from arch/sparc/include/asm/jump_label.h:7,
from include/linux/jump_label.h:5,
from include/linux/dynamic_debug.h:4,
from include/linux/kernel.h:20,
from include/linux/sched.h:54,
from arch/sparc/kernel/asm-offsets.c:13:
include/linux/cpumask.h: At top level:
include/linux/cpumask.h:13:26: error: variably modified 'bits' at file scope
include/linux/cpumask.h:659:14: error: variably modified 'cpu_all_bits' at file scope
include/linux/cpumask.h:705:2: error: variably modified 'cpu_bit_bitmap' at file scope
make[3]: *** [arch/sparc/kernel/asm-offsets.s] Error 1
make[2]: *** [prepare0] Error 2
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2
arch/sparc/include/asm/jump_label.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/sparc/include/asm/jump_label.h b/arch/sparc/include/asm/jump_label.h
index 62e66d7..65c0d30 100644
--- a/arch/sparc/include/asm/jump_label.h
+++ b/arch/sparc/include/asm/jump_label.h
@@ -4,7 +4,6 @@
#ifdef __KERNEL__
#include <linux/types.h>
-#include <asm/system.h>
#define JUMP_LABEL_NOP_SIZE 4
--
1.7.0.4
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF_EVENTS option
2010-10-25 15:52 [PATCH 1/3] sparc: don't #include asm/system.h in asm/jump_label.h Namhyung Kim
@ 2010-10-25 15:52 ` Namhyung Kim
2010-10-25 15:59 ` David Miller
2010-10-25 15:52 ` [PATCH 3/3] sparc32: fix build failure on CONFIG_SPARC_LEON Namhyung Kim
2010-10-25 15:57 ` [PATCH 1/3] sparc: don't #include asm/system.h in asm/jump_label.h David Miller
2 siblings, 1 reply; 14+ messages in thread
From: Namhyung Kim @ 2010-10-25 15:52 UTC (permalink / raw)
To: David S. Miller; +Cc: sparclinux, linux-kernel
Remove HAVE_PERF_EVENTS and PERF_USE_VMALLOC under config
SPARC because they're under SPARC64 too. Supporting
perf_event needs atomic64 operations but AFAIK sparc32
doesn't provide them, CMIIW. ;-) Also removes redundant
HAVE_IRQ_WORK line.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
arch/sparc/Kconfig | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index 3e9d314..4db8bc0 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -27,8 +27,6 @@ config SPARC
select RTC_CLASS
select RTC_DRV_M48T59
select HAVE_IRQ_WORK
- select HAVE_PERF_EVENTS
- select PERF_USE_VMALLOC
select HAVE_DMA_ATTRS
select HAVE_DMA_API_DEBUG
select HAVE_ARCH_JUMP_LABEL
@@ -55,7 +53,6 @@ config SPARC64
select RTC_DRV_BQ4802
select RTC_DRV_SUN4V
select RTC_DRV_STARFIRE
- select HAVE_IRQ_WORK
select HAVE_PERF_EVENTS
select PERF_USE_VMALLOC
--
1.7.0.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF_EVENTS option
2010-10-25 15:52 ` [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF_EVENTS option Namhyung Kim
@ 2010-10-25 15:59 ` David Miller
2010-10-25 16:31 ` Namhyung Kim
0 siblings, 1 reply; 14+ messages in thread
From: David Miller @ 2010-10-25 15:59 UTC (permalink / raw)
To: namhyung; +Cc: sparclinux, linux-kernel
From: Namhyung Kim <namhyung@gmail.com>
Date: Tue, 26 Oct 2010 00:52:37 +0900
> Remove HAVE_PERF_EVENTS and PERF_USE_VMALLOC under config
> SPARC because they're under SPARC64 too. Supporting
> perf_event needs atomic64 operations but AFAIK sparc32
> doesn't provide them, CMIIW. ;-) Also removes redundant
> HAVE_IRQ_WORK line.
>
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
The generic non-hw perf event stuff builds fine on sparc32,
please don't remove this unless you have a legitimate build
failure to report and fix.
Even if sparc32 doesn't provide atomic64_t support, it very
easily could do so using include/asm-generic/atomic64.h which
implements them using spinlocks.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF_EVENTS option
2010-10-25 15:59 ` David Miller
@ 2010-10-25 16:31 ` Namhyung Kim
2010-10-25 18:55 ` David Miller
0 siblings, 1 reply; 14+ messages in thread
From: Namhyung Kim @ 2010-10-25 16:31 UTC (permalink / raw)
To: David Miller; +Cc: sparclinux, linux-kernel
2010-10-25 (월), 08:59 -0700, David Miller:
> From: Namhyung Kim <namhyung@gmail.com>
> Date: Tue, 26 Oct 2010 00:52:37 +0900
>
> > Remove HAVE_PERF_EVENTS and PERF_USE_VMALLOC under config
> > SPARC because they're under SPARC64 too. Supporting
> > perf_event needs atomic64 operations but AFAIK sparc32
> > doesn't provide them, CMIIW. ;-) Also removes redundant
> > HAVE_IRQ_WORK line.
> >
> > Signed-off-by: Namhyung Kim <namhyung@gmail.com>
>
> The generic non-hw perf event stuff builds fine on sparc32,
> please don't remove this unless you have a legitimate build
> failure to report and fix.
>
> Even if sparc32 doesn't provide atomic64_t support, it very
> easily could do so using include/asm-generic/atomic64.h which
> implements them using spinlocks.
Now I see following build failure without this patch. Maybe some work is
needed to deal with atomic64_t. I'll try to prepare for it soon. Thanks.
CC arch/sparc/kernel/setup_32.o
In file included from arch/sparc/include/asm/local64.h:1:0,
from include/linux/perf_event.h:465,
from include/linux/ftrace_event.h:8,
from include/trace/syscall.h:6,
from include/linux/syscalls.h:76,
from arch/sparc/kernel/setup_32.c:23:
include/asm-generic/local64.h:62:2: error: expected
specifier-qualifier-list before 'atomic64_t'
In file included from include/linux/ftrace_event.h:8:0,
from include/trace/syscall.h:6,
from include/linux/syscalls.h:76,
from arch/sparc/kernel/setup_32.c:23:
include/linux/perf_event.h:722:2: error: expected
specifier-qualifier-list before 'atomic64_t'
include/linux/perf_event.h: In function 'perf_fetch_caller_regs':
include/linux/perf_event.h:1004:2: error: 'struct pt_regs' has no member
named 'tstate'
include/linux/perf_event.h:1004:2: error: 'struct pt_regs' has no member
named 'tpc'
include/linux/perf_event.h:1004:2: error: 'struct pt_regs' has no member
named 'tnpc'
include/linux/perf_event.h:1004:2: error: 'struct pt_regs' has no member
named 'tpc'
make[3]: *** [arch/sparc/kernel/setup_32.o] Error 1
make[2]: *** [arch/sparc/kernel] Error 2
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2
--
Regards,
Namhyung Kim
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF_EVENTS option
2010-10-25 16:31 ` Namhyung Kim
@ 2010-10-25 18:55 ` David Miller
0 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2010-10-25 18:55 UTC (permalink / raw)
To: namhyung; +Cc: sparclinux, linux-kernel
From: Namhyung Kim <namhyung@gmail.com>
Date: Tue, 26 Oct 2010 01:31:19 +0900
> 2010-10-25 (월), 08:59 -0700, David Miller:
>> From: Namhyung Kim <namhyung@gmail.com>
>> Date: Tue, 26 Oct 2010 00:52:37 +0900
>>
>> > Remove HAVE_PERF_EVENTS and PERF_USE_VMALLOC under config
>> > SPARC because they're under SPARC64 too. Supporting
>> > perf_event needs atomic64 operations but AFAIK sparc32
>> > doesn't provide them, CMIIW. ;-) Also removes redundant
>> > HAVE_IRQ_WORK line.
>> >
>> > Signed-off-by: Namhyung Kim <namhyung@gmail.com>
>>
>> The generic non-hw perf event stuff builds fine on sparc32,
>> please don't remove this unless you have a legitimate build
>> failure to report and fix.
>>
>> Even if sparc32 doesn't provide atomic64_t support, it very
>> easily could do so using include/asm-generic/atomic64.h which
>> implements them using spinlocks.
>
> Now I see following build failure without this patch. Maybe some work is
> needed to deal with atomic64_t. I'll try to prepare for it soon. Thanks.
Nevermind, I see the issue. Ok, your patch is fine:
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 3/3] sparc32: fix build failure on CONFIG_SPARC_LEON
2010-10-25 15:52 [PATCH 1/3] sparc: don't #include asm/system.h in asm/jump_label.h Namhyung Kim
2010-10-25 15:52 ` [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF_EVENTS option Namhyung Kim
@ 2010-10-25 15:52 ` Namhyung Kim
2010-10-25 16:00 ` David Miller
2010-10-25 15:57 ` [PATCH 1/3] sparc: don't #include asm/system.h in asm/jump_label.h David Miller
2 siblings, 1 reply; 14+ messages in thread
From: Namhyung Kim @ 2010-10-25 15:52 UTC (permalink / raw)
To: David S. Miller; +Cc: sparclinux, linux-kernel
CC arch/sparc/kernel/irq_32.o
arch/sparc/kernel/irq_32.c: In function 'request_fast_irq':
arch/sparc/kernel/irq_32.c:370:25: error: conflicting types for 'trapbase_cpu1'
arch/sparc/include/asm/leon.h:366:22: note: previous declaration of 'trapbase_cpu1' was here
arch/sparc/kernel/irq_32.c:370:40: error: conflicting types for 'trapbase_cpu2'
arch/sparc/include/asm/leon.h:367:22: note: previous declaration of 'trapbase_cpu2' was here
arch/sparc/kernel/irq_32.c:370:55: error: conflicting types for 'trapbase_cpu3'
arch/sparc/include/asm/leon.h:368:22: note: previous declaration of 'trapbase_cpu3' was here
make[3]: *** [arch/sparc/kernel/irq_32.o] Error 1
make[2]: *** [arch/sparc/kernel] Error 2
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
arch/sparc/kernel/irq_32.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/sparc/kernel/irq_32.c b/arch/sparc/kernel/irq_32.c
index 0116d8d..5ad6e5c 100644
--- a/arch/sparc/kernel/irq_32.c
+++ b/arch/sparc/kernel/irq_32.c
@@ -365,7 +365,7 @@ static int request_fast_irq(unsigned int irq,
unsigned long flags;
unsigned int cpu_irq;
int ret;
-#ifdef CONFIG_SMP
+#if defined CONFIG_SMP && !defined CONFIG_SPARC_LEON
struct tt_entry *trap_table;
extern struct tt_entry trapbase_cpu1, trapbase_cpu2, trapbase_cpu3;
#endif
@@ -425,7 +425,7 @@ static int request_fast_irq(unsigned int irq,
table[SP_TRAP_IRQ1+(cpu_irq-1)].inst_four = SPARC_NOP;
INSTANTIATE(sparc_ttable)
-#ifdef CONFIG_SMP
+#if defined CONFIG_SMP && !defined CONFIG_SPARC_LEON
trap_table = &trapbase_cpu1; INSTANTIATE(trap_table)
trap_table = &trapbase_cpu2; INSTANTIATE(trap_table)
trap_table = &trapbase_cpu3; INSTANTIATE(trap_table)
--
1.7.0.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] sparc32: fix build failure on CONFIG_SPARC_LEON
2010-10-25 15:52 ` [PATCH 3/3] sparc32: fix build failure on CONFIG_SPARC_LEON Namhyung Kim
@ 2010-10-25 16:00 ` David Miller
2010-10-25 16:07 ` Namhyung Kim
2010-10-25 16:11 ` Sam Ravnborg
0 siblings, 2 replies; 14+ messages in thread
From: David Miller @ 2010-10-25 16:00 UTC (permalink / raw)
To: namhyung; +Cc: sparclinux, linux-kernel
From: Namhyung Kim <namhyung@gmail.com>
Date: Tue, 26 Oct 2010 00:52:38 +0900
> CC arch/sparc/kernel/irq_32.o
> arch/sparc/kernel/irq_32.c: In function 'request_fast_irq':
> arch/sparc/kernel/irq_32.c:370:25: error: conflicting types for 'trapbase_cpu1'
I doubt SMP LEON chips even exist, so better to just anti-dep
this in arch/sparc/Kconfig
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] sparc32: fix build failure on CONFIG_SPARC_LEON
2010-10-25 16:00 ` David Miller
@ 2010-10-25 16:07 ` Namhyung Kim
2010-10-25 16:09 ` David Miller
2010-10-25 16:11 ` Sam Ravnborg
1 sibling, 1 reply; 14+ messages in thread
From: Namhyung Kim @ 2010-10-25 16:07 UTC (permalink / raw)
To: David Miller; +Cc: sparclinux, linux-kernel
2010-10-25 (월), 09:00 -0700, David Miller:
> From: Namhyung Kim <namhyung@gmail.com>
> Date: Tue, 26 Oct 2010 00:52:38 +0900
>
> > CC arch/sparc/kernel/irq_32.o
> > arch/sparc/kernel/irq_32.c: In function 'request_fast_irq':
> > arch/sparc/kernel/irq_32.c:370:25: error: conflicting types for 'trapbase_cpu1'
>
> I doubt SMP LEON chips even exist, so better to just anti-dep
> this in arch/sparc/Kconfig
If I understood correctly, you meant this?
diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index 4db8bc0..a6685ba 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -463,7 +463,7 @@ config SERIAL_CONSOLE
config SPARC_LEON
bool "Sparc Leon processor family"
- depends on SPARC32
+ depends on SPARC32 && !SMP
---help---
If you say Y here if you are running on a SPARC-LEON
processor.
The LEON processor is a synthesizable VHDL model of the
--
Regards,
Namhyung Kim
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 3/3] sparc32: fix build failure on CONFIG_SPARC_LEON
2010-10-25 16:07 ` Namhyung Kim
@ 2010-10-25 16:09 ` David Miller
0 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2010-10-25 16:09 UTC (permalink / raw)
To: namhyung; +Cc: sparclinux, linux-kernel
From: Namhyung Kim <namhyung@gmail.com>
Date: Tue, 26 Oct 2010 01:07:29 +0900
> 2010-10-25 (월), 09:00 -0700, David Miller:
>> From: Namhyung Kim <namhyung@gmail.com>
>> Date: Tue, 26 Oct 2010 00:52:38 +0900
>>
>> > CC arch/sparc/kernel/irq_32.o
>> > arch/sparc/kernel/irq_32.c: In function 'request_fast_irq':
>> > arch/sparc/kernel/irq_32.c:370:25: error: conflicting types for 'trapbase_cpu1'
>>
>> I doubt SMP LEON chips even exist, so better to just anti-dep
>> this in arch/sparc/Kconfig
>
> If I understood correctly, you meant this?
Yes, something like that.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] sparc32: fix build failure on CONFIG_SPARC_LEON
2010-10-25 16:00 ` David Miller
2010-10-25 16:07 ` Namhyung Kim
@ 2010-10-25 16:11 ` Sam Ravnborg
2010-10-25 18:53 ` David Miller
1 sibling, 1 reply; 14+ messages in thread
From: Sam Ravnborg @ 2010-10-25 16:11 UTC (permalink / raw)
To: David Miller; +Cc: namhyung, sparclinux, linux-kernel
On Mon, Oct 25, 2010 at 09:00:43AM -0700, David Miller wrote:
> From: Namhyung Kim <namhyung@gmail.com>
> Date: Tue, 26 Oct 2010 00:52:38 +0900
>
> > CC arch/sparc/kernel/irq_32.o
> > arch/sparc/kernel/irq_32.c: In function 'request_fast_irq':
> > arch/sparc/kernel/irq_32.c:370:25: error: conflicting types for 'trapbase_cpu1'
>
> I doubt SMP LEON chips even exist, so better to just anti-dep
> this in arch/sparc/Kconfig
I have a nice eval board at my desk with a dual-core LEON4 processor.
I only lack time to play with it...
Sam
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] sparc32: fix build failure on CONFIG_SPARC_LEON
2010-10-25 16:11 ` Sam Ravnborg
@ 2010-10-25 18:53 ` David Miller
2010-10-25 19:41 ` Sam Ravnborg
0 siblings, 1 reply; 14+ messages in thread
From: David Miller @ 2010-10-25 18:53 UTC (permalink / raw)
To: sam; +Cc: namhyung, sparclinux, linux-kernel
From: Sam Ravnborg <sam@ravnborg.org>
Date: Mon, 25 Oct 2010 18:11:22 +0200
> On Mon, Oct 25, 2010 at 09:00:43AM -0700, David Miller wrote:
>> From: Namhyung Kim <namhyung@gmail.com>
>> Date: Tue, 26 Oct 2010 00:52:38 +0900
>>
>> > CC arch/sparc/kernel/irq_32.o
>> > arch/sparc/kernel/irq_32.c: In function 'request_fast_irq':
>> > arch/sparc/kernel/irq_32.c:370:25: error: conflicting types for 'trapbase_cpu1'
>>
>> I doubt SMP LEON chips even exist, so better to just anti-dep
>> this in arch/sparc/Kconfig
>
> I have a nice eval board at my desk with a dual-core LEON4 processor.
> I only lack time to play with it...
Ok. But whenever someone gets a time to play with it and
verify it works, we can sort out this build failure by
modifying the code as needed.
But for now I prefer the Kconfig SMP dependency fix.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] sparc32: fix build failure on CONFIG_SPARC_LEON
2010-10-25 18:53 ` David Miller
@ 2010-10-25 19:41 ` Sam Ravnborg
2010-10-26 7:14 ` Daniel Hellstrom
0 siblings, 1 reply; 14+ messages in thread
From: Sam Ravnborg @ 2010-10-25 19:41 UTC (permalink / raw)
To: David Miller; +Cc: namhyung, sparclinux, linux-kernel
On Mon, Oct 25, 2010 at 11:53:31AM -0700, David Miller wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
> Date: Mon, 25 Oct 2010 18:11:22 +0200
>
> > On Mon, Oct 25, 2010 at 09:00:43AM -0700, David Miller wrote:
> >> From: Namhyung Kim <namhyung@gmail.com>
> >> Date: Tue, 26 Oct 2010 00:52:38 +0900
> >>
> >> > CC arch/sparc/kernel/irq_32.o
> >> > arch/sparc/kernel/irq_32.c: In function 'request_fast_irq':
> >> > arch/sparc/kernel/irq_32.c:370:25: error: conflicting types for 'trapbase_cpu1'
> >>
> >> I doubt SMP LEON chips even exist, so better to just anti-dep
> >> this in arch/sparc/Kconfig
> >
> > I have a nice eval board at my desk with a dual-core LEON4 processor.
> > I only lack time to play with it...
>
> Ok. But whenever someone gets a time to play with it and
> verify it works, we can sort out this build failure by
> modifying the code as needed.
>
> But for now I prefer the Kconfig SMP dependency fix.
Yup - I agree.
My only intention was to tell that such a processor exists in reality
and not only on paper.
Sam
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] sparc32: fix build failure on CONFIG_SPARC_LEON
2010-10-25 19:41 ` Sam Ravnborg
@ 2010-10-26 7:14 ` Daniel Hellstrom
0 siblings, 0 replies; 14+ messages in thread
From: Daniel Hellstrom @ 2010-10-26 7:14 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: David Miller, namhyung, sparclinux, linux-kernel
Sam Ravnborg wrote:
>On Mon, Oct 25, 2010 at 11:53:31AM -0700, David Miller wrote:
>
>
>>From: Sam Ravnborg <sam@ravnborg.org>
>>Date: Mon, 25 Oct 2010 18:11:22 +0200
>>
>>
>>
>>>On Mon, Oct 25, 2010 at 09:00:43AM -0700, David Miller wrote:
>>>
>>>
>>>>From: Namhyung Kim <namhyung@gmail.com>
>>>>Date: Tue, 26 Oct 2010 00:52:38 +0900
>>>>
>>>>
>>>>
>>>>> CC arch/sparc/kernel/irq_32.o
>>>>>arch/sparc/kernel/irq_32.c: In function 'request_fast_irq':
>>>>>arch/sparc/kernel/irq_32.c:370:25: error: conflicting types for 'trapbase_cpu1'
>>>>>
>>>>>
>>>>I doubt SMP LEON chips even exist, so better to just anti-dep
>>>>this in arch/sparc/Kconfig
>>>>
>>>>
>>>I have a nice eval board at my desk with a dual-core LEON4 processor.
>>>I only lack time to play with it...
>>>
>>>
>>Ok. But whenever someone gets a time to play with it and
>>verify it works, we can sort out this build failure by
>>modifying the code as needed.
>>
>>But for now I prefer the Kconfig SMP dependency fix.
>>
>>
>
>Yup - I agree.
>My only intention was to tell that such a processor exists in reality
>and not only on paper.
>
I stumbled into the same problem last weeks, enabling "Normal floppy
disk support" (BLK_DEV_FD) on the LEON makes this error appear. There is
no hardware for "Normal floppy disk support" on a LEON.
Regards,
Daniel Hellstrom
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] sparc: don't #include asm/system.h in asm/jump_label.h
2010-10-25 15:52 [PATCH 1/3] sparc: don't #include asm/system.h in asm/jump_label.h Namhyung Kim
2010-10-25 15:52 ` [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF_EVENTS option Namhyung Kim
2010-10-25 15:52 ` [PATCH 3/3] sparc32: fix build failure on CONFIG_SPARC_LEON Namhyung Kim
@ 2010-10-25 15:57 ` David Miller
2 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2010-10-25 15:57 UTC (permalink / raw)
To: namhyung; +Cc: sparclinux, linux-kernel
From: Namhyung Kim <namhyung@gmail.com>
Date: Tue, 26 Oct 2010 00:52:36 +0900
> It seems that #include <asm/system.h> makes a circular dependency
> between kernel.h and bitmap.h which breaks allmodconfig build.
> Removing the line makes no change because jump_label.h doesn't
> need it actually AFAICS. Compile tested on sparc32 allmodconfig.
>
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2010-10-26 9:25 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-25 15:52 [PATCH 1/3] sparc: don't #include asm/system.h in asm/jump_label.h Namhyung Kim
2010-10-25 15:52 ` [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF_EVENTS option Namhyung Kim
2010-10-25 15:59 ` David Miller
2010-10-25 16:31 ` Namhyung Kim
2010-10-25 18:55 ` David Miller
2010-10-25 15:52 ` [PATCH 3/3] sparc32: fix build failure on CONFIG_SPARC_LEON Namhyung Kim
2010-10-25 16:00 ` David Miller
2010-10-25 16:07 ` Namhyung Kim
2010-10-25 16:09 ` David Miller
2010-10-25 16:11 ` Sam Ravnborg
2010-10-25 18:53 ` David Miller
2010-10-25 19:41 ` Sam Ravnborg
2010-10-26 7:14 ` Daniel Hellstrom
2010-10-25 15:57 ` [PATCH 1/3] sparc: don't #include asm/system.h in asm/jump_label.h David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox