RE: [PATCH v6 09/10] scsi: ufs-exynos: add UFS host support for Exynos SoCs

Alim Akhtar
2020-04-21T00:59:33Z

Hi Avri,

> -----Original Message-----
> From: Avri Altman <Avri.Altman@wdc.com>
> Sent: 20 April 2020 15:56
> To: Alim Akhtar <alim.akhtar@samsung.com>; robh@kernel.org
> Cc: devicetree@vger.kernel.org; linux-scsi@vger.kernel.org; krzk@kernel.org;
> martin.petersen@oracle.com; kwmad.kim@samsung.com;
> stanley.chu@mediatek.com; cang@codeaurora.org; linux-samsung-
> soc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: RE: [PATCH v6 09/10] scsi: ufs-exynos: add UFS host support for Exynos
> SoCs
>
> > + struct exynos_ufs_drv_data *drv_data;
> > +
> > + u32 opts;
> > +#define EXYNOS_UFS_OPT_HAS_APB_CLK_CTRL BIT(0)
> > +#define EXYNOS_UFS_OPT_SKIP_CONNECTION_ESTAB BIT(1)
> > +#define EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL BIT(2)
> > +#define EXYNOS_UFS_OPT_BROKEN_RX_SEL_IDX BIT(3)
> > +#define EXYNOS_UFS_OPT_USE_SW_HIBERN8_TIMER BIT(4)
> Could not find where the last 2 are being used.
>
The assignment is done on line# 988 and 989 in exynos_ufs_init() and used in {pre,post}_hibern8,
let me see if I can add these in the list of .opts in drv_data.
Thanks for pointing this out.

> Thanks,
> Avri