RE: [PATCH v6 0/10] exynos-ufs: Add support for UFS HCI

Alim Akhtar
2020-04-18T13:08:34Z

Hi Avri,

> -----Original Message-----
> From: Avri Altman <Avri.Altman@wdc.com>
> Sent: 18 April 2020 18:09
> To: Alim Akhtar <alim.akhtar@samsung.com>; robh@kernel.org
> Cc: devicetree@vger.kernel.org; linux-scsi@vger.kernel.org; krzk@kernel.org;
> martin.petersen@oracle.com; kwmad.kim@samsung.com;
> stanley.chu@mediatek.com; cang@codeaurora.org; linux-samsung-
> soc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: RE: [PATCH v6 0/10] exynos-ufs: Add support for UFS HCI
>
>
> >
> > This patch-set introduces UFS (Universal Flash Storage) host
> > controller support for Samsung family SoC. Mostly, it consists of UFS
> > PHY and host specific driver.
> >
> > - Changes since v5:
> > * re-introduce various quicks which was removed because of no driver
> > * consumer of those quirks, initial 4 patches does the same.
> You forgot to add those quirks to ufs_fixups.

ufs_fixups are for ufs __device__ related quirks, what I have posted are all host controller quirks.
Please have a look on the other quirks related to HCI like UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION
Which is used in other vendor HCI driver.
Let me know if I am missing anything here.

> Each patch that introduces a quirk needs to introduce its users as well - This is
> the reason it was removed in the first place.
>
> Thanks,
> Avri