From: Michael Ellerman <michael@ellerman.id.au>
To: Joe Perches <joe@perches.com>
Cc: Jiri Kosina <trivial@kernel.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/39] arch/powerpc: Update WARN uses
Date: Mon, 01 Nov 2010 22:02:14 +1100 [thread overview]
Message-ID: <1288609334.10671.4.camel@concordia> (raw)
In-Reply-To: <c6c46b5924e1cc9720d3ad76e6c11e982bd661e5.1288471898.git.joe@perches.com>
[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]
On Sat, 2010-10-30 at 14:08 -0700, Joe Perches wrote:
> Coalesce long formats.
> Align arguments.
> Add missing newlines.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/powerpc/kernel/hw_breakpoint.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c
> index 5ecd040..d7343a7 100644
> --- a/arch/powerpc/kernel/hw_breakpoint.c
> +++ b/arch/powerpc/kernel/hw_breakpoint.c
> @@ -270,8 +270,8 @@ int __kprobes hw_breakpoint_handler(struct die_args *args)
> * message to let the user know about it.
> */
> if (!stepped) {
> - WARN(1, "Unable to handle hardware breakpoint. Breakpoint at "
> - "0x%lx will be disabled.", info->address);
> + WARN(1, "Unable to handle hardware breakpoint. Breakpoint at 0x%lx will be disabled.\n",
> + info->address);
That appears to have done nothing other than turn a short line into one
that is now > 80 columns. Is that the latest fad?
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-11-01 11:02 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-30 21:08 [PATCH 00/39] Cleanup WARN #defines Joe Perches
2010-10-30 21:08 ` [PATCH 01/39] include/asm-generic/bug.h: Update WARN macros Joe Perches
2010-10-30 21:08 ` [PATCH 02/39] arch/alpha: Update WARN uses Joe Perches
2010-10-30 21:17 ` Matt Turner
2010-10-30 21:28 ` Joe Perches
2010-10-31 1:11 ` Michael Cree
2010-10-31 1:38 ` Joe Perches
2010-10-30 21:08 ` [PATCH 03/39] arch/arm: " Joe Perches
2010-10-30 21:08 ` [PATCH 04/39] arch/powerpc: " Joe Perches
2010-11-01 11:02 ` Michael Ellerman [this message]
2010-11-01 14:41 ` Joe Perches
2010-11-02 0:26 ` Michael Ellerman
2010-11-02 1:50 ` Joe Perches
2010-11-02 3:20 ` Michael Ellerman
2010-10-30 21:08 ` [PATCH 05/39] arch/x86: " Joe Perches
2010-10-31 1:38 ` Rafael J. Wysocki
2010-10-30 21:08 ` [PATCH 06/39] drivers/acpi: " Joe Perches
2010-10-30 21:08 ` [PATCH 07/39] drivers/base: " Joe Perches
2010-10-30 21:08 ` [PATCH 08/39] drivers/block: " Joe Perches
2010-10-30 21:08 ` [PATCH 09/39] drivers/cpuidle: " Joe Perches
2010-10-30 21:08 ` [PATCH 10/39] drivers/firewire: " Joe Perches
2010-10-30 21:57 ` Stefan Richter
2010-10-30 21:08 ` [PATCH 11/39] drivers/firmware: " Joe Perches
2010-10-30 21:08 ` [PATCH 12/39] drivers/gpio: " Joe Perches
2010-10-30 21:08 ` [PATCH 13/39] drivers/gpu/drm: " Joe Perches
2010-10-30 21:08 ` [PATCH 14/39] drivers/media/video: " Joe Perches
2010-10-30 21:08 ` [PATCH 15/39] drivers/mfd: " Joe Perches
2010-11-26 10:02 ` Samuel Ortiz
2010-10-30 21:08 ` [PATCH 16/39] drivers/net/can: " Joe Perches
2010-11-09 17:23 ` David Miller
2010-10-30 21:08 ` [PATCH 17/39] drivers/net/usb: " Joe Perches
2010-11-09 17:23 ` David Miller
2010-10-30 21:08 ` [PATCH 18/39] drivers/net/wireless/iwlwifi: " Joe Perches
2010-10-30 21:08 ` [PATCH 19/39] drivers/regulator: " Joe Perches
2010-11-01 13:25 ` Mark Brown
2010-10-30 21:08 ` [PATCH 20/39] drivers/scsi/fcoe: " Joe Perches
2010-10-30 21:08 ` [PATCH 21/39] drivers/staging: " Joe Perches
2010-11-09 23:50 ` Greg KH
2010-10-30 21:08 ` [PATCH 22/39] drivers/usb/musb: " Joe Perches
2010-11-05 11:44 ` Felipe Balbi
2010-11-05 13:54 ` Jiri Kosina
2010-11-05 13:56 ` Felipe Balbi
2010-10-30 21:08 ` [PATCH 23/39] drivers/video/omap2/dss: " Joe Perches
2010-10-30 21:08 ` [PATCH 24/39] fs/nfsd: " Joe Perches
2010-10-30 21:08 ` [PATCH 25/39] fs/notify/inotify: " Joe Perches
2010-10-30 21:08 ` [PATCH 26/39] fs/sysfs: " Joe Perches
2010-10-30 21:08 ` [PATCH 27/39] fs/proc: " Joe Perches
2010-10-30 21:08 ` [PATCH 28/39] fs: " Joe Perches
2010-10-30 21:08 ` [PATCH 29/39] include/linux/device.h: " Joe Perches
2010-10-30 21:08 ` [PATCH 30/39] kernel/irq: " Joe Perches
2010-10-30 21:08 ` [PATCH 31/39] kernel/panic.c: Update warn_slowpath to use %pV Joe Perches
2010-10-30 21:08 ` [PATCH 32/39] kernel: Update WARN uses Joe Perches
2010-10-30 21:08 ` [PATCH 33/39] lib: " Joe Perches
2010-10-30 21:08 ` [PATCH 34/39] mm: " Joe Perches
2010-11-08 12:03 ` Michał Nazarewicz
2010-10-30 21:08 ` [PATCH 35/39] net/core/dev.c: " Joe Perches
2010-11-09 17:23 ` David Miller
2010-10-30 21:08 ` [PATCH 36/39] net/ipv4/tcp.c: " Joe Perches
2010-11-09 17:23 ` David Miller
2010-10-30 21:08 ` [PATCH 37/39] net/mac80211: " Joe Perches
2010-10-31 7:33 ` Johannes Berg
2010-10-30 21:08 ` [PATCH 38/39] net/rfkill/input.c: " Joe Perches
2010-10-30 21:08 ` [PATCH 39/39] sound/soc/codecs/wm_hubs.c: " Joe Perches
2010-11-01 19:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288609334.10671.4.camel@concordia \
--to=michael@ellerman.id.au \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox