From: Joe Perches <joe@perches.com>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Ravikiran G Thirumalai <kiran@scalex86.org>
Subject: Re: lessen the impact of a deprecated warning in hugetlbfs
Date: Tue, 02 Nov 2010 20:04:22 -0700 [thread overview]
Message-ID: <1288753462.7326.20.camel@Joe-Laptop> (raw)
In-Reply-To: <20101102180622.GA12620@redhat.com>
On Tue, 2010-11-02 at 14:06 -0400, Dave Jones wrote:
> WARN_ONCE is a bit strong for a deprecation warning, given that it spews a
> huge backtrace.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6.36.noarch/fs/hugetlbfs/inode.c~ 2010-11-02 14:01:19.489289082 -0400
> +++ linux-2.6.36.noarch/fs/hugetlbfs/inode.c 2010-11-02 14:02:19.947986439 -0400
> @@ -915,8 +915,7 @@ struct file *hugetlb_file_setup(const ch
> if (creat_flags == HUGETLB_SHMFS_INODE && !can_do_hugetlb_shm()) {
> *user = current_user();
> if (user_shm_lock(size, *user)) {
> - WARN_ONCE(1,
> - "Using mlock ulimits for SHM_HUGETLB deprecated\n");
> + printk_once("Using mlock ulimits for SHM_HUGETLB deprecated\n");
Please add a KERN_NOTICE or similar.
The grammar could be improved via "is deprecated"
next prev parent reply other threads:[~2010-11-03 3:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 18:06 lessen the impact of a deprecated warning in hugetlbfs Dave Jones
2010-11-03 3:04 ` Joe Perches [this message]
2010-11-13 1:54 ` Ravikiran G Thirumalai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288753462.7326.20.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=davej@redhat.com \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox