The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jiri Kosina <trivial@kernel.org>
Cc: Jaya Kumar <jayalk@intworks.biz>,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xen.org,
	virtualization@lists.osdl.org
Subject: [PATCH V2 36/49] drivers/video: Use vzalloc
Date: Thu, 04 Nov 2010 22:31:36 -0700	[thread overview]
Message-ID: <1288935096.18440.33.camel@Joe-Laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.1011031108260.11625@router.home>
In-Reply-To: <cover.1288925424.git.joe@perches.com>

Signed-off-by: Joe Perches <joe@perches.com>
---
V2 - Fixed vmalloc/vzalloc typo
Thanks to Dave Young for noticing.

 drivers/video/arcfb.c        |    5 ++---
 drivers/video/broadsheetfb.c |    4 +---
 drivers/video/hecubafb.c     |    5 ++---
 drivers/video/metronomefb.c  |    4 +---
 drivers/video/xen-fbfront.c  |    3 +--
 5 files changed, 7 insertions(+), 14 deletions(-)

diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c
index 3ec4923..86573e2 100644
--- a/drivers/video/arcfb.c
+++ b/drivers/video/arcfb.c
@@ -515,11 +515,10 @@ static int __devinit arcfb_probe(struct platform_device *dev)
 
 	/* We need a flat backing store for the Arc's
 	   less-flat actual paged framebuffer */
-	if (!(videomemory = vmalloc(videomemorysize)))
+	videomemory = vzalloc(videomemorysize);
+	if (!videomemory)
 		return retval;
 
-	memset(videomemory, 0, videomemorysize);
-
 	info = framebuffer_alloc(sizeof(struct arcfb_par), &dev->dev);
 	if (!info)
 		goto err;
diff --git a/drivers/video/broadsheetfb.c b/drivers/video/broadsheetfb.c
index ebda687..377dde3 100644
--- a/drivers/video/broadsheetfb.c
+++ b/drivers/video/broadsheetfb.c
@@ -1101,12 +1101,10 @@ static int __devinit broadsheetfb_probe(struct platform_device *dev)
 
 	videomemorysize = roundup((dpyw*dpyh), PAGE_SIZE);
 
-	videomemory = vmalloc(videomemorysize);
+	videomemory = vzalloc(videomemorysize);
 	if (!videomemory)
 		goto err_fb_rel;
 
-	memset(videomemory, 0, videomemorysize);
-
 	info->screen_base = (char *)videomemory;
 	info->fbops = &broadsheetfb_ops;
 
diff --git a/drivers/video/hecubafb.c b/drivers/video/hecubafb.c
index c77bcc6..a941e6f 100644
--- a/drivers/video/hecubafb.c
+++ b/drivers/video/hecubafb.c
@@ -231,11 +231,10 @@ static int __devinit hecubafb_probe(struct platform_device *dev)
 
 	videomemorysize = (DPY_W*DPY_H)/8;
 
-	if (!(videomemory = vmalloc(videomemorysize)))
+	videomemory = vzalloc(videomemorysize);
+	if (!videomemory)
 		return retval;
 
-	memset(videomemory, 0, videomemorysize);
-
 	info = framebuffer_alloc(sizeof(struct hecubafb_par), &dev->dev);
 	if (!info)
 		goto err_fballoc;
diff --git a/drivers/video/metronomefb.c b/drivers/video/metronomefb.c
index 63ed3b7..c0c358c 100644
--- a/drivers/video/metronomefb.c
+++ b/drivers/video/metronomefb.c
@@ -628,12 +628,10 @@ static int __devinit metronomefb_probe(struct platform_device *dev)
 	/* we need to add a spare page because our csum caching scheme walks
 	 * to the end of the page */
 	videomemorysize = PAGE_SIZE + (fw * fh);
-	videomemory = vmalloc(videomemorysize);
+	videomemory = vzalloc(videomemorysize);
 	if (!videomemory)
 		goto err_fb_rel;
 
-	memset(videomemory, 0, videomemorysize);
-
 	info->screen_base = (char __force __iomem *)videomemory;
 	info->fbops = &metronomefb_ops;
 
diff --git a/drivers/video/xen-fbfront.c b/drivers/video/xen-fbfront.c
index 428d273..81fcaea 100644
--- a/drivers/video/xen-fbfront.c
+++ b/drivers/video/xen-fbfront.c
@@ -395,10 +395,9 @@ static int __devinit xenfb_probe(struct xenbus_device *dev,
 	spin_lock_init(&info->dirty_lock);
 	spin_lock_init(&info->resize_lock);
 
-	info->fb = vmalloc(fb_size);
+	info->fb = vzalloc(fb_size);
 	if (info->fb == NULL)
 		goto error_nomem;
-	memset(info->fb, 0, fb_size);
 
 	info->nr_pages = (fb_size + PAGE_SIZE - 1) >> PAGE_SHIFT;
 
-- 
1.7.3.1.g432b3.dirty



  parent reply	other threads:[~2010-11-05  5:31 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-30 21:35 [PATCH] cgroup: Avoid a memset by using vzalloc Jesper Juhl
2010-10-30 23:34 ` Minchan Kim
2010-10-31 17:33   ` Balbir Singh
2010-11-01  5:40     ` Jesper Juhl
2010-11-03 14:38       ` Christoph Lameter
2010-11-03 15:20         ` jovi zhang
2010-11-03 15:31           ` Christoph Lameter
2010-11-03 15:48           ` Joe Perches
2010-11-03 16:10             ` Christoph Lameter
2010-11-04 21:43               ` Jesper Juhl
     [not found]               ` <cover.1288925424.git.joe@perches.com>
2010-11-05  3:07                 ` [PATCH 01/49] arch/ia64: Use vzalloc Joe Perches
2010-11-05  3:07                 ` [PATCH 02/49] arch/mips: " Joe Perches
2010-11-05 10:51                   ` Ralf Baechle
2010-11-05  3:07                 ` [PATCH 03/49] arch/powerpc: " Joe Perches
2010-11-05 13:08                   ` [Cbe-oss-dev] " Jeremy Kerr
2010-11-05  3:07                 ` [PATCH 04/49] arch/s390: " Joe Perches
2010-11-05  3:07                 ` [PATCH 05/49] arch/x86: " Joe Perches
2010-11-05  4:22                   ` Takuya Yoshikawa
2010-11-05  3:07                 ` [PATCH 06/49] crypto: " Joe Perches
2010-11-27  8:31                   ` Herbert Xu
2010-11-05  3:07                 ` [PATCH 07/49] drivers/atm: " Joe Perches
2010-11-05  3:07                 ` [PATCH 08/49] drivers/block: " Joe Perches
2010-11-05  3:07                 ` [PATCH 09/49] drivers/char: " Joe Perches
2010-11-05  3:07                 ` [PATCH 10/49] drivers/gpu: " Joe Perches
2010-11-05  9:29                   ` Thomas Hellstrom
2010-11-05  3:07                 ` [PATCH 11/49] drivers/hid: " Joe Perches
2010-11-05  3:07                 ` [PATCH 12/49] drivers/infiniband: " Joe Perches
2011-01-12 19:12                   ` Roland Dreier
2010-11-05  3:07                 ` [PATCH 13/49] drivers/isdn: " Joe Perches
2010-11-05  3:07                 ` [PATCH 14/49] drivers/md: " Joe Perches
2010-11-05  3:07                 ` [PATCH 15/49] drivers/media: " Joe Perches
2010-11-05  3:07                 ` [PATCH 16/49] drivers/mtd: " Joe Perches
2010-11-13 11:19                   ` Artem Bityutskiy
2010-11-05  3:07                 ` [PATCH 17/49] drivers/net/cxgb3: " Joe Perches
2010-11-05  3:07                 ` [PATCH 18/49] drivers/net/cxgb4: " Joe Perches
2010-11-05  3:07                 ` [PATCH 19/49] drivers/net/e1000: " Joe Perches
2010-11-05  3:07                 ` [PATCH 20/49] drivers/net/e1000e: " Joe Perches
2010-11-05  3:07                 ` [PATCH 21/49] drivers/net/ehea: " Joe Perches
2010-11-05  3:07                 ` [PATCH 22/49] drivers/net/igb: " Joe Perches
2010-11-05  3:07                 ` [PATCH 23/49] drivers/net/igbvf: " Joe Perches
2010-11-05 11:58                   ` Rose, Gregory V
2010-11-05  3:07                 ` [PATCH 24/49] drivers/net/ixgb: " Joe Perches
2010-11-05  3:07                 ` [PATCH 25/49] drivers/net/ixgbe: " Joe Perches
2010-11-05  3:07                 ` [PATCH 26/49] drivers/net/ixgbevf: " Joe Perches
2010-11-05 11:59                   ` Rose, Gregory V
2010-11-05  3:07                 ` [PATCH 27/49] drivers/net/netxen: " Joe Perches
2010-11-05  5:18                   ` Amit Salecha
2010-11-05  3:07                 ` [PATCH 28/49] drivers/net/pch_gbe: " Joe Perches
2010-11-05  3:07                 ` [PATCH 29/49] drivers/net/qlcnic: " Joe Perches
2010-11-05  3:07                 ` [PATCH 30/49] drivers/net/sfc: " Joe Perches
2010-11-05  3:07                 ` [PATCH 31/49] drivers/net/vxge: " Joe Perches
2010-11-05  3:07                 ` [PATCH 32/49] drivers/net/bnx2.c: " Joe Perches
2010-11-05  3:07                 ` [PATCH 33/49] drivers/s390: " Joe Perches
2010-11-05  3:07                 ` [PATCH 34/49] drivers/scsi: " Joe Perches
2010-11-05  3:07                 ` [PATCH 35/49] drivers/staging: " Joe Perches
2010-11-05  3:08                 ` [PATCH 36/49] drivers/video: " Joe Perches
2010-11-05  5:27                   ` Dave Young
2010-11-05  5:31                     ` Joe Perches
2010-11-08 16:43                   ` Konrad Rzeszutek Wilk
2010-11-05  3:08                 ` [PATCH 37/49] fs/ext4: " Joe Perches
     [not found]                   ` <F35C793E-7CBA-4631-8928-C34D5B39F148@dilger.ca>
2010-11-05  7:18                     ` [PATCH V2 " Joe Perches
2010-12-20  3:22                       ` Ted Ts'o
2010-11-05  3:08                 ` [PATCH 38/49] fs/jffs2: " Joe Perches
2010-11-13 11:19                   ` Artem Bityutskiy
2010-11-05  3:08                 ` [PATCH 39/49] fs/reiserfs: " Joe Perches
2010-11-05  3:08                 ` [PATCH 40/49] fs/udf: " Joe Perches
2010-11-05  9:11                   ` Jan Kara
2010-11-05  9:15                     ` Peter Bortas
2010-11-05  9:30                       ` Jan Kara
2010-11-05  3:08                 ` [PATCH 41/49] fs/xfs: " Joe Perches
2010-11-05 17:09                   ` Alex Elder
2010-11-05  3:08                 ` [PATCH 42/49] include/linux/coda_linux.h: " Joe Perches
2010-11-05  3:08                 ` [PATCH 43/49] kernel: " Joe Perches
2010-11-05  3:08                 ` [PATCH 44/49] mm: " Joe Perches
2010-11-05  3:08                 ` [PATCH 45/49] net/core/pktgen.c: " Joe Perches
2010-11-05  3:08                 ` [PATCH 46/49] net/netfilter: " Joe Perches
2010-11-05  6:30                   ` Eric Dumazet
2010-11-05  6:55                     ` Joe Perches
2010-11-05  7:16                       ` Eric Dumazet
2010-11-05 17:01                         ` Jesper Juhl
2010-11-05 15:10                       ` Jiri Kosina
2010-11-05 15:25                         ` Joe Perches
2010-11-05  3:08                 ` [PATCH 47/49] net/rds: " Joe Perches
2010-11-05  3:08                 ` [PATCH 48/49] sound/oss/dev_table.c: " Joe Perches
2010-11-22  6:59                   ` Takashi Iwai
2010-11-05  3:08                 ` [PATCH 49/49] virt/kvm/kvm_main.c: " Joe Perches
2010-11-05  4:25                   ` Takuya Yoshikawa
2010-11-05  4:44                     ` Joe Perches
2010-11-05  5:31                 ` Joe Perches [this message]
2010-11-03 16:37           ` [PATCH] cgroup: Avoid a memset by using vzalloc Américo Wang
2010-11-01 22:00 ` Paul Menage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288935096.18440.33.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=jayalk@intworks.biz \
    --cc=jeremy.fitzhardinge@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    --cc=virtualization@lists.osdl.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox