From: Richard Purdie <rpurdie@rpsys.net>
To: Randy Dunlap <randy.dunlap@oracle.com>, akpm <akpm@linux-foundation.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
torvalds <torvalds@linux-foundation.org>,
Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: [PATCH] leds-net5501: taints kernel, add license
Date: Fri, 05 Nov 2010 13:40:26 +0000 [thread overview]
Message-ID: <1288964426.28481.15863.camel@rex> (raw)
In-Reply-To: <20101104102800.6b1cc210.randy.dunlap@oracle.com>
On Thu, 2010-11-04 at 10:28 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Add MODULE_LICENSE() that matches file comments so that kernel
> is not tainted.
>
> leds_net5501: module license 'unspecified' taints kernel.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Richard Purdie <rpurdie@linux.intel.com>
> ---
> drivers/leds/leds-net5501.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Alessandro, why does this module not have a module_exit() function?
> I.e., why can it not be unloaded?
>
>
> --- lnx-2637-rc1.orig/drivers/leds/leds-net5501.c
> +++ lnx-2637-rc1/drivers/leds/leds-net5501.c
> @@ -92,3 +92,5 @@ unmap:
> }
>
> arch_initcall(soekris_init);
> +
> +MODULE_LICENSE("GPL");
>
next prev parent reply other threads:[~2010-11-05 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 17:28 [PATCH] leds-net5501: taints kernel, add license Randy Dunlap
2010-11-05 13:40 ` Richard Purdie [this message]
2010-11-05 21:35 ` Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288964426.28481.15863.camel@rex \
--to=rpurdie@rpsys.net \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox