Re: [PATCH] HID: roccat: Add support for Roccat Kone[+]

Dmitry Torokhov
2010-11-11T09:00:24Z

Hi Stefan,

On Sun, Oct 24, 2010 at 07:57:05PM +0200, Stefan Achatz wrote:
> +
> +static int koneplus_create_sysfs_attributes(struct usb_interface *intf)
> +{
> + int retval;
> +
> + retval = sysfs_create_group(&intf->dev.kobj, &koneplus_attribute_group);
> + if (retval)
> + goto exit_1;
> +
> + retval = sysfs_create_bin_file(&intf->dev.kobj,
> + &koneplus_profile_settings_attr);
> + if (retval)
> + goto exit_2;
> +
> + retval = sysfs_create_bin_file(&intf->dev.kobj,
> + &koneplus_profile1_settings_attr);
> + if (retval)
> + goto exit_3;
> +

...

> +
> + retval = sysfs_create_bin_file(&intf->dev.kobj,
> + &koneplus_sensor_attr);
> + if (retval)
> + goto exit_17;
> +

I think we are ready to sysfs_binary_attribute_group ;) Please add it to
sysfs code and send it to GregKH.

Thanks.

--
Dmitry