From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Darren Hart <dvhart@linux.intel.com>,
linux-kernel@vger.kernel.org,
Matt Fleming <matt@console-pimps.org>,
mingo@elte.hu, eric.dumazet@gmail.com, jkacur@redhat.com,
Darren Hart <dvhltc@us.ibm.com>
Subject: Re: [PATCH 3/3] futex: add futex_q static initializer
Date: Mon, 08 Nov 2010 19:12:31 +0100 [thread overview]
Message-ID: <1289239951.2191.0.camel@laptop> (raw)
In-Reply-To: <alpine.LFD.2.00.1011081724460.2900@localhost6.localdomain6>
On Mon, 2010-11-08 at 17:42 +0100, Thomas Gleixner wrote:
> > +#define FUTEX_Q_INIT \
> > + { /* list gets initialized in queue_me()*/ \
> > + .task = NULL, NULL, FUTEX_KEY_INIT \
> > + , NULL, NULL, NULL, FUTEX_BITSET_MATCH_ANY }
> > +
>
> That should be a static readonly variable with a proper C99
> initializer.
Well, it doesn't need to actually be an existing variable, but yeah it
should definately use C99 initializers.
next prev parent reply other threads:[~2010-11-08 18:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 21:54 [PATCH 0/3] futex: compiler warning and cleanups Darren Hart
2010-10-27 21:54 ` [PATCH 1/3] futex: fix compiler warnings in exit_robust_list Darren Hart
2010-11-04 10:49 ` [1/3] " Uwe Kleine-König
2010-11-04 19:00 ` [PATCH V2] " Darren Hart
2010-11-10 12:20 ` Thomas Gleixner
[not found] ` <tip-4c115e951d80aff126468adaec7a6c7854f61ab8@git.kernel.org>
2010-11-10 16:14 ` [tip:core/urgent] futex: Address " Darren Hart
2010-11-10 20:16 ` Uwe Kleine-König
2010-11-10 20:21 ` Darren Hart
2010-11-10 20:22 ` Darren Hart
2010-10-27 21:54 ` [PATCH 2/3] futex: replace fshared and clockrt with combined flags Darren Hart
2010-11-08 16:47 ` Thomas Gleixner
2010-11-08 21:10 ` [PATCH V2] " Darren Hart
2010-10-27 21:54 ` [PATCH 3/3] futex: add futex_q static initializer Darren Hart
2010-11-08 16:42 ` Thomas Gleixner
2010-11-08 18:12 ` Peter Zijlstra [this message]
2010-11-08 19:39 ` Thomas Gleixner
2010-11-08 21:12 ` [PATCH V2] " Darren Hart
2010-11-08 21:40 ` [PATCH V3] " Darren Hart
2010-11-08 21:48 ` Thomas Gleixner
2010-11-08 21:59 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289239951.2191.0.camel@laptop \
--to=peterz@infradead.org \
--cc=dvhart@linux.intel.com \
--cc=dvhltc@us.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox