* [PATCH] ASoC: Fix compile error if CONFIG_DEBUG_FS is not configured
@ 2010-11-09 9:06 Axel Lin
2010-11-09 10:01 ` Liam Girdwood
2010-11-09 17:47 ` Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2010-11-09 9:06 UTC (permalink / raw)
To: linux-kernel; +Cc: Liam Girdwood, Mark Brown, Jarkko Nikula
Add soc_init_card_debugfs and soc_cleanup_card_debugfs functions to fix below error.
CC sound/soc/soc-core.o
sound/soc/soc-core.c: In function 'soc_probe':
sound/soc/soc-core.c:1689: error: implicit declaration of function 'soc_init_card_debugfs'
sound/soc/soc-core.c: In function 'soc_remove':
sound/soc/soc-core.c:1718: error: implicit declaration of function 'soc_cleanup_card_debugfs'
make[2]: *** [sound/soc/soc-core.o] Error 1
make[1]: *** [sound/soc] Error 2
make: *** [sound] Error 2
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/soc-core.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index f030521..c18ce1d 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -401,6 +401,14 @@ static inline void soc_init_codec_debugfs(struct snd_soc_codec *codec)
static inline void soc_cleanup_codec_debugfs(struct snd_soc_codec *codec)
{
}
+
+static inline void soc_init_card_debugfs(struct snd_soc_card *card)
+{
+}
+
+static inline void soc_cleanup_card_debugfs(struct snd_soc_card *card)
+{
+}
#endif
#ifdef CONFIG_SND_SOC_AC97_BUS
--
1.7.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Fix compile error if CONFIG_DEBUG_FS is not configured
2010-11-09 9:06 [PATCH] ASoC: Fix compile error if CONFIG_DEBUG_FS is not configured Axel Lin
@ 2010-11-09 10:01 ` Liam Girdwood
2010-11-09 17:23 ` Jarkko Nikula
2010-11-09 17:47 ` Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Liam Girdwood @ 2010-11-09 10:01 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Mark Brown, Jarkko Nikula
On Tue, 2010-11-09 at 17:06 +0800, Axel Lin wrote:
> Add soc_init_card_debugfs and soc_cleanup_card_debugfs functions to fix below error.
>
> CC sound/soc/soc-core.o
> sound/soc/soc-core.c: In function 'soc_probe':
> sound/soc/soc-core.c:1689: error: implicit declaration of function 'soc_init_card_debugfs'
> sound/soc/soc-core.c: In function 'soc_remove':
> sound/soc/soc-core.c:1718: error: implicit declaration of function 'soc_cleanup_card_debugfs'
> make[2]: *** [sound/soc/soc-core.o] Error 1
> make[1]: *** [sound/soc] Error 2
> make: *** [sound] Error 2
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Fix compile error if CONFIG_DEBUG_FS is not configured
2010-11-09 10:01 ` Liam Girdwood
@ 2010-11-09 17:23 ` Jarkko Nikula
0 siblings, 0 replies; 4+ messages in thread
From: Jarkko Nikula @ 2010-11-09 17:23 UTC (permalink / raw)
To: Liam Girdwood; +Cc: Axel Lin, linux-kernel, Mark Brown
On Tue, 09 Nov 2010 10:01:06 +0000
Liam Girdwood <lrg@slimlogic.co.uk> wrote:
> On Tue, 2010-11-09 at 17:06 +0800, Axel Lin wrote:
> > Add soc_init_card_debugfs and soc_cleanup_card_debugfs functions to fix below error.
> >
> > CC sound/soc/soc-core.o
> > sound/soc/soc-core.c: In function 'soc_probe':
> > sound/soc/soc-core.c:1689: error: implicit declaration of function 'soc_init_card_debugfs'
> > sound/soc/soc-core.c: In function 'soc_remove':
> > sound/soc/soc-core.c:1718: error: implicit declaration of function 'soc_cleanup_card_debugfs'
> > make[2]: *** [sound/soc/soc-core.o] Error 1
> > make[1]: *** [sound/soc] Error 2
> > make: *** [sound] Error 2
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
> --
Oops...
Acked-by: Jarkko Nikula <jhnikula@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Fix compile error if CONFIG_DEBUG_FS is not configured
2010-11-09 9:06 [PATCH] ASoC: Fix compile error if CONFIG_DEBUG_FS is not configured Axel Lin
2010-11-09 10:01 ` Liam Girdwood
@ 2010-11-09 17:47 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2010-11-09 17:47 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Liam Girdwood, Jarkko Nikula
On Tue, Nov 09, 2010 at 05:06:44PM +0800, Axel Lin wrote:
> Add soc_init_card_debugfs and soc_cleanup_card_debugfs functions to fix below error.
>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-09 17:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-09 9:06 [PATCH] ASoC: Fix compile error if CONFIG_DEBUG_FS is not configured Axel Lin
2010-11-09 10:01 ` Liam Girdwood
2010-11-09 17:23 ` Jarkko Nikula
2010-11-09 17:47 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox