The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Jean Delvare <khali@linux-fr.org>,
	Simon Guinot <sguinot@lacie.com>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH v2] hwmon: (gpio-fan) Fix fan_ctrl_init error path
Date: Tue, 9 Nov 2010 10:20:56 -0800	[thread overview]
Message-ID: <1289326856.22931.211.camel@groeck-laptop> (raw)
In-Reply-To: <1289292108.28671.1.camel@mola>

On Tue, 2010-11-09 at 03:41 -0500, Axel Lin wrote:
> In current implementation, the sysfs entries is not removed before return -ENODEV.
> 
> Creating the sysfs attribute should be the last thing done by the function,
> after all the rest has been successful.
> Otherwise there is a small window during which user-space can access the attribute
> but the driver isn't ready to deal with the requests.
> 
> Fix it by moving sysfs_create_group to be the last thing done by the function.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Applied.

Thanks,
Guenter



      parent reply	other threads:[~2010-11-09 18:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-09  8:41 [PATCH v2] hwmon: (gpio-fan) Fix fan_ctrl_init error path Axel Lin
2010-11-09  9:41 ` [lm-sensors] " Simon Guinot
2010-11-09 18:20 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289326856.22931.211.camel@groeck-laptop \
    --to=guenter.roeck@ericsson.com \
    --cc=axel.lin@gmail.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=sguinot@lacie.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox