From: Peter Zijlstra <peterz@infradead.org>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Matt Fleming <matt@console-pimps.org>,
"Zhang, Rui" <rui.zhang@intel.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [RFC PATCH 1/2] perf: Enable group siblings on exec if attr::enable_on_exec set
Date: Wed, 10 Nov 2010 15:54:42 +0100 [thread overview]
Message-ID: <1289400882.2191.136.camel@laptop> (raw)
In-Reply-To: <1289400543.2479.41.camel@localhost>
On Wed, 2010-11-10 at 22:49 +0800, Lin Ming wrote:
> > I don't mind the patch too much (although I would like to avoid that
> > double sibling iteration in both group_enable_on_exec() and
> > __perf_event_mark_enabled()), but I think it can already work as is.
>
> I got it now!
>
> Another stupid patch, sorry.
Well, I wouldn't call it a stupid patch, it does fix something that is
evidently non-obvious so it might be worth considering it on that merit.
I'm simply pointing out that what you're trying to achieve might be
possible without changing code.
prev parent reply other threads:[~2010-11-10 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 6:15 [RFC PATCH 1/2] perf: Enable group siblings on exec if attr::enable_on_exec set Lin Ming
2010-11-10 12:19 ` Peter Zijlstra
2010-11-10 14:17 ` Lin Ming
2010-11-10 14:38 ` Peter Zijlstra
2010-11-10 14:49 ` Lin Ming
2010-11-10 14:54 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289400882.2191.136.camel@laptop \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox