Re: [Jfs-discussion] [PATCH 5/6] fs/jfs: Add printf format/argument verification

[Dave Kleikamp <shaggy@linux.vnet.ibm.com>]

On Wed, 2010-11-10 at 15:46 -0800, Joe Perches wrote:
> Add __attribute__((format... to jfs_error.
> 
> All arguments matched formats, no other changes necessary.
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Acked-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>

Would you like to push this patchset as a group, or would you like me to
push this patch through the jfs tree?

Shaggy

> ---
>  fs/jfs/jfs_superblock.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/jfs/jfs_superblock.h b/fs/jfs/jfs_superblock.h
> index 884fc21..1da2538 100644
> --- a/fs/jfs/jfs_superblock.h
> +++ b/fs/jfs/jfs_superblock.h
> @@ -108,6 +108,8 @@ struct jfs_superblock {
> 
>  extern int readSuper(struct super_block *, struct buffer_head **);
>  extern int updateSuper(struct super_block *, uint);
> +
> +__attribute__((format(printf, 2, 3)))
>  extern void jfs_error(struct super_block *, const char *, ...);
>  extern int jfs_mount(struct super_block *);
>  extern int jfs_mount_rw(struct super_block *, int);

-- 
Dave Kleikamp
IBM Linux Technology Center