Re: [RFC][PATCH 15/22] sched: add traceporints for -deadline tasks

[Peter Zijlstra <peterz@infradead.org>]

On Fri, 2010-10-29 at 08:38 +0200, Raistlin wrote:
> Add tracepoints for the most notable events related to -deadline
> tasks scheduling (new task arrival, context switch, runtime accounting,
> bandwidth enforcement timer, etc.).
> 
> Signed-off-by: Dario Faggioli <raistlin@linux.it>
> Signed-off-by: Harald Gustafsson <harald.gustafsson@ericsson.com>
> ---
>  include/trace/events/sched.h |  203 +++++++++++++++++++++++++++++++++++++++++-
>  kernel/sched.c               |    2 +
>  kernel/sched_dl.c            |   21 +++++
>  3 files changed, 225 insertions(+), 1 deletions(-)
> 
> diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
> index f633478..03baa17 100644
> --- a/include/trace/events/sched.h
> +++ b/include/trace/events/sched.h
> @@ -304,7 +304,6 @@ DECLARE_EVENT_CLASS(sched_stat_template,
>  			(unsigned long long)__entry->delay)
>  );
>  
> -
>  /*
>   * Tracepoint for accounting wait time (time the task is runnable
>   * but not actually running due to scheduler contention).
> @@ -363,6 +362,208 @@ TRACE_EVENT(sched_stat_runtime,
>  );
>  
>  /*
> + * Tracepoint for task switches involving -deadline tasks:
> + */
> +TRACE_EVENT(sched_switch_dl,


We've already got sched_switch(), better extend that. Same for the next
patch, we already have a migration tracepoint, extend that.

And I recently rejected a fifo push/pull tracepoint patch from Steve
because the migration tracepoint was able to provide the same
information.