From: Zhang Rui <rui.zhang@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Matthew Garrett <mjg@redhat.com>,
"Brown, Len" <len.brown@intel.com>
Subject: Re: [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2)
Date: Fri, 12 Nov 2010 10:57:02 +0800 [thread overview]
Message-ID: <1289530622.8148.1500.camel@rui> (raw)
In-Reply-To: <1289524357.8148.1396.camel@rui>
On Fri, 2010-11-12 at 09:12 +0800, Zhang Rui wrote:
> On Sun, 2010-09-05 at 21:51 +0800, Chris Wilson wrote:
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Matthew Garrett <mjg@redhat.com>
> > Cc: Zhang Rui <rui.zhang@intel.com>
> > Cc: Len Brown <len.brown@intel.com>
>
> Acked-by: Zhang Rui <rui.zhang@intel.com>
>
> > ---
> > include/acpi/video.h | 5 ++++-
> > 1 files changed, 4 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/acpi/video.h b/include/acpi/video.h
> > index 551793c..0e98e67 100644
> > --- a/include/acpi/video.h
> > +++ b/include/acpi/video.h
> > @@ -1,6 +1,10 @@
> > #ifndef __ACPI_VIDEO_H
> > #define __ACPI_VIDEO_H
> >
> > +#include <linux/errno.h> /* for ENODEV */
> > +
> > +struct acpi_device;
> > +
Oh, btw, this line is actually not needed,
because acpi_video_get_edid is not invoked in any place when CONFIG_ACPI
is cleared.
> > #define ACPI_VIDEO_DISPLAY_CRT 1
> > #define ACPI_VIDEO_DISPLAY_TV 2
> > #define ACPI_VIDEO_DISPLAY_DVI 3
> > @@ -26,4 +30,3 @@ static inline int acpi_video_get_edid(struct acpi_device *device, int type,
> > #endif
> >
> > #endif
> > -
>
next prev parent reply other threads:[~2010-11-12 2:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-05 13:35 [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI Chris Wilson
2010-09-05 13:51 ` [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2) Chris Wilson
2010-11-10 12:08 ` Chris Wilson
2010-11-10 20:33 ` Rafael J. Wysocki
2010-11-12 1:12 ` Zhang Rui
2010-11-12 2:57 ` Zhang Rui [this message]
2010-11-30 23:52 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289530622.8148.1500.camel@rui \
--to=rui.zhang@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox