From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Andi Kleen <andi@firstfloor.org>
Cc: eranian@google.com, linux-kernel@vger.kernel.org,
cjashfor@linux.vnet.ibm.com, mingo@elte.hu, fweisbec@gmail.com,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/2] perf-events: Add support for supplementary event registers v2
Date: Sat, 13 Nov 2010 11:32:47 +0100 [thread overview]
Message-ID: <1289644367.2084.526.camel@laptop> (raw)
In-Reply-To: <20101113101148.GB6418@gargoyle.fritz.box>
On Sat, 2010-11-13 at 11:13 +0100, Andi Kleen wrote:
> > Hrmm,. this doesn't really scale right wrt multiple extra_regs.
> >
> > You made the extra_regs thing fairly extensible, but the above doesn't
> > really work well if there's multiple extra regs (say OFFCORE and
> > LBR_CONFIG -- possibly even the two OFFCORE regs present on westmere).
> >
> > It basically needs a per-core state for each extra_reg possible.
>
> It shouldn't be too hard to extend it to use a table. I didn't want
> to do that for the first iteration. I guess it could be done as followons
> once LBR is implemented.
Isn't it also relevant for the two offcore regs for wsm?
next prev parent reply other threads:[~2010-11-13 10:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 16:55 [PATCH 1/2] perf-events: Add support for supplementary event registers v2 Andi Kleen
2010-11-12 16:55 ` [PATCH 2/2] perf-events: Fix LLC-* events on Intel Nehalem/Westmere v2 Andi Kleen
2010-11-12 17:17 ` [PATCH 1/2] perf-events: Add support for supplementary event registers v2 Peter Zijlstra
2010-11-12 17:17 ` Stephane Eranian
2010-11-12 17:33 ` Peter Zijlstra
2010-11-12 21:26 ` Stephane Eranian
2010-11-13 10:17 ` Andi Kleen
2010-11-13 10:34 ` Peter Zijlstra
2010-11-15 11:03 ` Stephane Eranian
2010-11-15 11:06 ` Andi Kleen
2010-11-15 11:00 ` Stephane Eranian
2010-11-12 17:23 ` Peter Zijlstra
2010-11-13 10:13 ` Andi Kleen
2010-11-13 10:32 ` Peter Zijlstra [this message]
2010-11-15 11:01 ` Stephane Eranian
2010-11-15 11:06 ` Peter Zijlstra
2010-11-15 11:17 ` Andi Kleen
2010-11-15 11:18 ` Stephane Eranian
2010-11-15 11:31 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289644367.2084.526.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox