public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	Jason Wessel <jason.wessel@windriver.com>
Subject: Re: [PATCH 2/2] perf,hw_breakpoint: Initialize hardware api earlier
Date: Sat, 13 Nov 2010 22:46:06 +0100	[thread overview]
Message-ID: <1289684766.2109.326.camel@laptop> (raw)
In-Reply-To: <1289684273-26770-3-git-send-regression-fweisbec@gmail.com>

On Sat, 2010-11-13 at 22:37 +0100, Frederic Weisbecker wrote:
> From: Jason Wessel <jason.wessel@windriver.com>
> 
> When using early debugging, the kernel does not initialize the
> hw_breakpoint API early enough and causes the late initialization of
> the kernel debugger to fail. The boot arguments are:
> 
>     earlyprintk=vga ekgdboc=kbd kgdbwait
> 
> Then simply type "go" at the kdb prompt and boot. The kernel will
> later emit the message:
> 
>     kgdb: Could not allocate hwbreakpoints
> 
> And at that point the kernel debugger will cease to work correctly.
> 
> The solution is to initialize the hw_breakpoint at the same time that
> all the other perf call backs are initialized instead of using a
> core_initcall() initialization which happens well after the kernel
> debugger can make use of hardware breakpoints.

How early is it needed? I've got a patch converting the x86 (still need
to do the other hardware pmus) to early_initcall() instead of random
places in the arch bringup (notably before the perf core init).



  reply	other threads:[~2010-11-13 21:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-13 21:37 [GIT PULL] hw-breakpoint fixes Frederic Weisbecker
2010-11-13 21:37 ` [PATCH 1/2] x86: Ignore trap bits on single step exceptions Frederic Weisbecker
2010-11-24 20:32   ` Michael Stefaniuc
2010-11-25  7:47     ` Frederic Weisbecker
2010-11-13 21:37 ` [PATCH 2/2] perf,hw_breakpoint: Initialize hardware api earlier Frederic Weisbecker
2010-11-13 21:46   ` Peter Zijlstra [this message]
2010-11-14 13:33     ` Jason Wessel
2010-11-16 21:24       ` Peter Zijlstra
2010-11-18 16:09         ` Jason Wessel
2010-11-18  9:39 ` [GIT PULL] hw-breakpoint fixes Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289684766.2109.326.camel@laptop \
    --to=a.p.zijlstra@chello.nl \
    --cc=fweisbec@gmail.com \
    --cc=jason.wessel@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox