Re: [PATCH v6] Add generic exponentially weighted moving average (EWMA) function

Andrew Morton
2010-11-11T04:05:25Z

On Thu, 11 Nov 2010 12:47:56 +0900 Bruno Randolf <br1@einfach.org> wrote:

>
> ...
>
> The original idea for this implementation came from the rt2x00 driver
> (rt2x00link.c). I would like to use it in several places in the mac80211 and
> ath5k code and I hope it can be useful in many other places in the kernel code.
>
> ...
>
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -21,7 +21,7 @@ lib-y += kobject.o kref.o klist.o
>
> obj-y += bcd.o div64.o sort.o parser.o halfmd4.o debug_locks.o random32.o \
> bust_spinlocks.o hexdump.o kasprintf.o bitmap.o scatterlist.o \
> - string_helpers.o gcd.o lcm.o list_sort.o uuid.o
> + string_helpers.o gcd.o lcm.o list_sort.o uuid.o average.o

It would be a bit strange to merge this into 2.6.36-rcX when there are
no callers. But you do want it to be present in some tree for your own
testing and distribution purposes.

So perhaps it would be best to merge this via the wireless tree, so
everything exists in one place and it can be fed into linux-next and
into mainline in an orderly fashion.

If that sounds like a plan then I can send this patch in John's
direction. Which means that if he merges it into mainline without also
merging any of your patches which _use_ this function then we still end
up with unused code in mainline, but at least that way it wasn't my fault ;)

Let me know your thoughts?

(And it's a bit sad that the function will exist in the base vmlinux
even for people who don't ever use it, but that's a problem which we
don't really have a good solution for).