Re: [PATCH v6] Add generic exponentially weighted moving average (EWMA) function

KOSAKI Motohiro
2010-11-14T05:07:41Z

> > Why do ewma_init() and ewma_add() return their first argument? They look
> > to me like they can be straight-forward void functions.
>
> You are right, for ewma_init() it does not make sense.
>
> For ewma_add() I think it does. This has been discussed before (e.g.
> http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-10/msg09124.html).
> Some people might want to get the value when they add a sample by using
> ewma_get(ewma_add(&ewma, val));

ewma_add(&ewma, val);
ewma_get(&ewma);

is enough simpler and cleaner. I don't oppse this :)