linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Joey Lee <jlee@novell.com>,
	mingo@elte.hu, airlied@redhat.com, "Brown, Len" <lenb@kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"Zhang, Rui" <rui.zhang@intel.com>
Subject: [PATCH]  do not select ACPI_VIDEO in poulsbo stub driver
Date: Tue, 16 Nov 2010 14:04:53 +0800	[thread overview]
Message-ID: <1289887493.8148.2040.camel@rui> (raw)


the poulsbo stub driver should not select ACPI video driver.

The reason why i915 driver selects ACPI video driver is that it needs some
cooperation between these two drivers during initialization, or else the
system may hang.

So if users want ACPI backlight control, please set CONFIG_ACPI_VIDEO manually.

http://marc.info/?l=linux-acpi&m=128952659018533&w=2

CC: Ingo Molnar <mingo@elte.hu>
CC: Dave Airlie <airlied@redhat.com>
CC: Lee, Chun-Yi <joeyli.kernel@gmail.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
 drivers/gpu/stub/Kconfig   |   11 +----------
 drivers/gpu/stub/poulsbo.c |    5 +----
 2 files changed, 2 insertions(+), 14 deletions(-)

Index: linux-2.6/drivers/gpu/stub/Kconfig
===================================================================
--- linux-2.6.orig/drivers/gpu/stub/Kconfig
+++ linux-2.6/drivers/gpu/stub/Kconfig
@@ -1,16 +1,7 @@
 config STUB_POULSBO
 	tristate "Intel GMA500 Stub Driver"
 	depends on PCI
-	# Poulsbo stub depends on ACPI_VIDEO when ACPI is enabled
-	# but for select to work, need to select ACPI_VIDEO's dependencies, ick
-	select VIDEO_OUTPUT_CONTROL if ACPI
-	select BACKLIGHT_CLASS_DEVICE if ACPI
-	select INPUT if ACPI
-	select ACPI_VIDEO if ACPI
 	help
 	  Choose this option if you have a system that has Intel GMA500
 	  (Poulsbo) integrated graphics. If M is selected, the module will
-	  be called Poulsbo. This driver is a stub driver for Poulsbo that
-	  will call poulsbo.ko to enable the acpi backlight control sysfs
-	  entry file because there have no poulsbo native driver can support
-	  intel opregion.
+	  be called Poulsbo.
Index: linux-2.6/drivers/gpu/stub/poulsbo.c
===================================================================
--- linux-2.6.orig/drivers/gpu/stub/poulsbo.c
+++ linux-2.6/drivers/gpu/stub/poulsbo.c
@@ -11,8 +11,6 @@
 
 #include <linux/module.h>
 #include <linux/pci.h>
-#include <linux/acpi.h>
-#include <acpi/video.h>
 
 #define DRIVER_NAME "poulsbo"
 
@@ -29,12 +27,11 @@ static DEFINE_PCI_DEVICE_TABLE(pciidlist
 
 static int poulsbo_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 {
-	return acpi_video_register();
+	return 0;
 }
 
 static void poulsbo_remove(struct pci_dev *pdev)
 {
-	acpi_video_unregister();
 }
 
 static struct pci_driver poulsbo_driver = {



             reply	other threads:[~2010-11-16  6:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-16  6:04 Zhang Rui [this message]
2010-11-16 14:11 ` [PATCH] do not select ACPI_VIDEO in poulsbo stub driver Matthew Garrett
  -- strict thread matches above, loose matches on Subject: below --
2010-11-16  7:34 Joey Lee
2010-11-17  0:42 ` Zhang Rui
2010-11-17  3:04 Joey Lee
2010-11-17  3:16 ` Zhang Rui
2010-11-17  7:34 Joey Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289887493.8148.2040.camel@rui \
    --to=rui.zhang@intel.com \
    --cc=airlied@redhat.com \
    --cc=jlee@novell.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).