Re: [RFC][PATCH 1/5] [PATCH 1/5] events: Add EVENT_FS the event filesystem

Ted Ts'o
2010-11-17T18:42:39Z

On Wed, Nov 17, 2010 at 04:03:32PM +0100, Ingo Molnar wrote:
>
> I think Arjan's complaints at the KS stemmed from prior sporadic
> declarations on lkml that there is no tracepoint ABI _at all_, and
> that powertop/latencytop could break anytime.
>
> But in reality i strongly disagree with such declarations, and
> tracepoint data that is used by PowerTop/timechart/latencytop or
> perf is and was an ABI, simple as that - and i've been enforcing
> that for two years. (We have so few good instrumentation tools that
> we _really_ dont want to break them.)

There was general consensus at the kernel summit that the tracepoints,
being deliberately in /sys/kernel/debug was unstable and today exposes
internal implementation details --- and that that people putting
different traceponts in Documentation/ABI/{testing,stable,unstable}
simply doesn't work.

Heck, I've recently had to make changes to tracepoints because
otherwise perf would fall over dead when it tripped over an ext4
tracepoint, due to its limitations dealing with what we could put into
TP_PRINTK(). Saying that tracepoints are stable ABI that must never
change, forever and ever, amen, is simply a non-starter.

> I simply dont see the 'problem' that is being solved here. We had a
> stable ABI and we didnt break sysprof or powertop/latencytop in the
> past and wont break it in the future either.

I think the general consensus is that we didn't have a stable ABI, and
the tension between what kernel developers need for debugging, which
of necessity is kernel version specific, and what gets exposed as a
stable ABI that tools can depend upon, is not one that can be
resolved.

Regards,

- Ted