Re: [PATCH 1/2] drivers: regulator: core: use pr_fmt

[Joe Perches <joe@perches.com>]

On Wed, 2010-11-17 at 15:30 -0800, Daniel Walker wrote:
> This adds a pr_fmt line which uses the __func__ macro. I also
> convert the current pr_ lines to remove their __func__ usage.
[]
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> @@ -765,8 +767,8 @@ static int machine_constraints_voltage(struct regulator_dev *rdev,
>  
>  		/* else require explicit machine-level constraints */
>  		if (cmin <= 0 || cmax <= 0 || cmax < cmin) {
> -			pr_err("%s: %s '%s' voltage constraints\n",
> -				       __func__, "invalid", name);
> +			pr_err("%s '%s' voltage constraints\n", "invalid",
> +				name);

Using a separate pointer for invalid and unsupportable
doesn't save much text space and is very hard to grep.

I think it's more intelligible as:

			pr_err("%s: Invalid voltage constraints\n", name);

> -			pr_err("%s: %s '%s' voltage constraints\n",
> -				       __func__, "unsupportable", name);
> +			pr_err("%s '%s' voltage constraints\n", "unsupportable",
> +				name);

and
			pr_err("%s: Unsupportable voltage constraints\n", name);