From: Peter Zijlstra <peterz@infradead.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
"Dima Zavin" <dima@android.com>, "Ingo Molnar" <mingo@elte.hu>,
"Arve Hjønnevåg" <arve@android.com>
Subject: Re: [PATCH 5/5] sched: use the old min_vruntime when normalizing on dequeue
Date: Sat, 20 Nov 2010 13:33:30 +0100 [thread overview]
Message-ID: <1290256410.2124.0.camel@laptop> (raw)
In-Reply-To: <1290250511.2118.7.camel@laptop>
On Sat, 2010-11-20 at 11:55 +0100, Peter Zijlstra wrote:
> Right, so assuming the reasoning is right (my brain still needs to wake
> up) the patch is weird, by not simply move the code bock up and avoid
> the whole extra variable like so?
Also, clearly that comments needs addressing..
prev parent reply other threads:[~2010-11-20 12:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-20 2:08 [PATCH 0/5] [RFC] Trivial scheduler related Android patches John Stultz
2010-11-20 2:08 ` [PATCH 1/5] sched: Enable might_sleep before initializing drivers John Stultz
2010-11-20 10:42 ` Peter Zijlstra
2010-11-20 2:08 ` [PATCH 2/5] sched: make task dump print all 15 chars of proc comm John Stultz
2010-11-23 10:21 ` [tip:sched/core] sched: Make " tip-bot for Erik Gilling
2010-11-20 2:08 ` [PATCH 3/5] scheduler: cpuacct: Enable platform hooks to track cpuusage for CPU frequencies John Stultz
2010-11-20 10:48 ` Peter Zijlstra
2010-11-22 5:51 ` Florian Mickler
2010-11-22 10:43 ` Peter Zijlstra
2010-11-22 12:23 ` Florian Mickler
2010-11-23 2:05 ` Mike Chan
2010-11-23 11:35 ` Peter Zijlstra
2010-11-20 2:08 ` [PATCH 4/5] scheduler: cpuacct: Enable platform callbacks for cpuacct power tracking John Stultz
2010-11-20 2:08 ` [PATCH 5/5] sched: use the old min_vruntime when normalizing on dequeue John Stultz
2010-11-20 10:55 ` Peter Zijlstra
2010-11-20 12:33 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290256410.2124.0.camel@laptop \
--to=peterz@infradead.org \
--cc=arve@android.com \
--cc=dima@android.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox