From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 1/2] regulator: Fix obfuscated log messages
Date: Mon, 22 Nov 2010 14:31:36 +0000 [thread overview]
Message-ID: <1290436296.3309.55.camel@odin> (raw)
In-Reply-To: <1290433879-6184-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Mon, 2010-11-22 at 13:51 +0000, Mark Brown wrote:
> Don't use %s to format fixed static strings into log messages, it just
> makes searching for and reading the message in the kernel source
> needlessly hard.
Both Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2010-11-22 14:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 13:51 [PATCH 1/2] regulator: Fix obfuscated log messages Mark Brown
2010-11-22 13:51 ` [PATCH 2/2] regulator: Remove regulator core version announcement Mark Brown
2010-11-22 14:31 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290436296.3309.55.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox