From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: tglx <tglx@linutronix.de>, Steven Rostedt <rostedt@goodmis.org>,
fweisbec <fweisbec@gmail.com>,
Stephane Eranian <eranian@google.com>, paulus <paulus@samba.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] perf: Tracepoint collection support
Date: Mon, 22 Nov 2010 18:17:42 +0100 [thread overview]
Message-ID: <1290446262.2072.339.camel@laptop> (raw)
In-Reply-To: <1290445737.2072.338.camel@laptop>
On Mon, 2010-11-22 at 18:08 +0100, Peter Zijlstra wrote:
> + if (event->attr.config != ~0ULL) {
> + err = __perf_event_add_tp(event, event->attr.config);
> + if (err)
> + return err;
> + err = perf_trace_init(event, event->attr.config);
> + if (err)
> + return err;
> + }
That's a double perf_trace_init() call, __perf_event_add_tp() already
does that.
next prev parent reply other threads:[~2010-11-22 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 17:08 [RFC][PATCH] perf: Tracepoint collection support Peter Zijlstra
2010-11-22 17:17 ` Peter Zijlstra [this message]
[not found] ` <AANLkTimyvB5tkHuYyitT_UA3sg0-TY+g6L040ncZQxnr@mail.gmail.com>
2010-11-23 6:41 ` Lin Ming
2010-11-23 12:32 ` [RFC][PATCH] perf: Tracepoint collection support -v2 Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290446262.2072.339.camel@laptop \
--to=peterz@infradead.org \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox