From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Peter Hsiang <Peter.Hsiang@maxim-ic.com>,
Jesse Marroquin <jesse.marroquin@maxim-ic.com>
Subject: Re: [PATCH 1/3] ASoC: max98088 - fix a memory leak
Date: Tue, 23 Nov 2010 10:33:24 +0000 [thread overview]
Message-ID: <1290508404.3449.7.camel@odin> (raw)
In-Reply-To: <1290498981.7286.4.camel@mola>
On Tue, 2010-11-23 at 15:56 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/codecs/max98088.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c
> index 4ee5b1a..b679586 100644
> --- a/sound/soc/codecs/max98088.c
> +++ b/sound/soc/codecs/max98088.c
> @@ -2020,7 +2020,10 @@ err_access:
>
> static int max98088_remove(struct snd_soc_codec *codec)
> {
> + struct max98088_priv *max98088 = snd_soc_codec_get_drvdata(codec);
> +
> max98088_set_bias_level(codec, SND_SOC_BIAS_OFF);
> + kfree(max98088->eq_texts);
>
> return 0;
> }
All
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-11-23 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 7:56 [PATCH 1/3] ASoC: max98088 - fix a memory leak Axel Lin
2010-11-23 7:57 ` [PATCH 2/3] ASoC: wm8904 - fix memory leaks Axel Lin
2010-11-23 7:58 ` [PATCH 3/3] ASoC: wm8994 " Axel Lin
2010-11-23 10:33 ` Liam Girdwood [this message]
2010-11-23 14:53 ` [PATCH 1/3] ASoC: max98088 - fix a memory leak Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290508404.3449.7.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=Peter.Hsiang@maxim-ic.com \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jesse.marroquin@maxim-ic.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox