From: Jamie Iles <jamie@jamieiles.com>
To: linux-kernel@vger.kernel.org
Cc: Jamie Iles <jamie@jamieiles.com>,
Haavard Skinnemoen <haavard.skinnemoen@atmel.com>,
Dan Williams <dan.j.williams@intel.com>,
Jamie Iles <jamie.iles@picochip.com>
Subject: [PATCH 1/4] dmaengine/dw_dmac: don't scan descriptors if no xfers in progress
Date: Tue, 23 Nov 2010 11:06:08 +0000 [thread overview]
Message-ID: <1290510371-23077-2-git-send-email-jamie@jamieiles.com> (raw)
In-Reply-To: <1290510371-23077-1-git-send-email-jamie@jamieiles.com>
Some hardware (picoChip picoXCell in particular) sometimes has
the block transfer complete bit being set for a channel after the
whole transfer has completed. If we don't have any transfers in the
active list then don't bother to scan the descriptors. This often
happens in normal operation and doesn't require the channel to be
reset.
Cc: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Jamie Iles <jamie.iles@picochip.com>
---
drivers/dma/dw_dmac.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index a3991ab..08c51d4 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
@@ -291,6 +291,9 @@ static void dwc_scan_descriptors(struct dw_dma *dw, struct dw_dma_chan *dwc)
return;
}
+ if (list_empty(&dwc->active_list))
+ return;
+
dev_vdbg(chan2dev(&dwc->chan), "scan_descriptors: llp=0x%x\n", llp);
list_for_each_entry_safe(desc, _desc, &dwc->active_list, desc_node) {
--
1.7.2.3
next prev parent reply other threads:[~2010-11-23 11:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 11:06 [PATCH 0/4] dmaengine/dw_dmac: enhancements to allow use on other platforms Jamie Iles
2010-11-23 11:06 ` Jamie Iles [this message]
2010-12-03 23:20 ` [PATCH 1/4] dmaengine/dw_dmac: don't scan descriptors if no xfers in progress Dan Williams
2010-11-23 11:06 ` [PATCH 2/4] dmaengine/dw_dmac: allow src/dst masters to be configured at runtime Jamie Iles
2010-12-03 23:56 ` Dan Williams
2010-12-08 1:03 ` Dan Williams
2010-12-08 1:20 ` Jamie Iles
2010-12-08 6:41 ` Hans-Christian Egtvedt
2010-12-08 8:09 ` Jamie Iles
2010-11-23 11:06 ` [PATCH 3/4] dmaengine/dw_dmac: provide a mechanism to indicate private devices Jamie Iles
2010-11-23 11:06 ` [PATCH 4/4] avr32: at32ap700x: specify DMA src and dst masters Jamie Iles
2010-12-08 12:36 ` Hans-Christian Egtvedt
2010-12-03 23:34 ` [PATCH 0/4] dmaengine/dw_dmac: enhancements to allow use on other platforms Dan Williams
2010-12-05 20:05 ` Håvard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290510371-23077-2-git-send-email-jamie@jamieiles.com \
--to=jamie@jamieiles.com \
--cc=dan.j.williams@intel.com \
--cc=haavard.skinnemoen@atmel.com \
--cc=jamie.iles@picochip.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox