public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: a.p.zijlstra@chello.nl
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] perf: Limit event refresh to sampling event
Date: Tue, 23 Nov 2010 16:21:44 +0100	[thread overview]
Message-ID: <1290525705-6265-2-git-send-email-fbuihuu@gmail.com> (raw)
In-Reply-To: <1290525705-6265-1-git-send-email-fbuihuu@gmail.com>

From: Franck Bui-Huu <fbuihuu@gmail.com>

Signed-off-by: Franck Bui-Huu <fbuihuu@gmail.com>
---
 kernel/perf_event.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/perf_event.c b/kernel/perf_event.c
index df7869f..813b09e 100644
--- a/kernel/perf_event.c
+++ b/kernel/perf_event.c
@@ -1072,7 +1072,7 @@ static int perf_event_refresh(struct perf_event *event, int refresh)
 	/*
 	 * not supported on inherited events
 	 */
-	if (event->attr.inherit)
+	if (event->attr.inherit || !is_sampling_event(event))
 		return -EINVAL;
 
 	atomic_add(refresh, &event->event_limit);
-- 
1.7.3.2


  reply	other threads:[~2010-11-23 15:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-23 15:21 [PATCH 1/3] perf: introduce is_sampling_event() Franck Bui-Huu
2010-11-23 15:21 ` Franck Bui-Huu [this message]
2010-11-23 15:21   ` [PATCH 3/3] perf: don't bother to init the hrtimer for no SW sampling counters Franck Bui-Huu
2010-11-26 15:04     ` [tip:perf/core] perf: Don't " tip-bot for Franck Bui-Huu
2010-11-26 15:04   ` [tip:perf/core] perf: Limit event refresh to sampling event tip-bot for Franck Bui-Huu
2010-11-26 15:03 ` [tip:perf/core] perf: Introduce is_sampling_event() tip-bot for Franck Bui-Huu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290525705-6265-2-git-send-email-fbuihuu@gmail.com \
    --to=vagabon.xyz@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox