From: Joe Perches <joe@perches.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hid: hidpidff: Use pr_<level>
Date: Tue, 23 Nov 2010 07:24:40 -0800 [thread overview]
Message-ID: <1290525880.28824.17.camel@Joe-Laptop> (raw)
In-Reply-To: <alpine.LNX.2.00.1011231336420.18801@pobox.suse.cz>
On Tue, 2010-11-23 at 13:36 +0100, Jiri Kosina wrote:
> On Mon, 22 Nov 2010, Joe Perches wrote:
> > Prefixes were not standardized in this module.
> > Some used "hid-pidff:", others "hidpidff:".
> > Add pr_fmt(fmt) KBUILD_MODNAME ": " fmt to standardize prefix uses.
> Hmm, how about using dev_dbg instead? So that we get the bonus of having
> the device name there for free?
Too much restructuring required.
There's no device available in many of the pr_debug uses.
next prev parent reply other threads:[~2010-11-23 15:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 7:35 [PATCH] hid: hidpidff: Use pr_<level> Joe Perches
2010-11-23 12:36 ` Jiri Kosina
2010-11-23 15:24 ` Joe Perches [this message]
2010-11-25 21:45 ` Jiri Kosina
2010-11-23 21:54 ` [PATCH] hid: Add and use hid_<level>: dev_<level> equivalents Joe Perches
2010-12-09 13:54 ` Jiri Kosina
2010-12-10 3:29 ` [PATCH 0/6] hid: Use hid_<level> for logging messages Joe Perches
2010-12-10 3:29 ` [PATCH 1/6] hid: Add and use hid_<level>: dev_<level> equivalents Joe Perches
2010-12-10 3:29 ` [PATCH 2/6] hid: Use vzalloc for vmalloc/memset(,0...) Joe Perches
2010-12-10 3:29 ` [PATCH 3/6] hid: Remove __inline__ from functions Joe Perches
2010-12-10 3:29 ` [PATCH 4/6] hid: Remove unnecessary multiplies from loops Joe Perches
2010-12-10 3:29 ` [PATCH 5/6] hid: Hoist assigns from ifs Joe Perches
2010-12-10 3:29 ` [PATCH 6/6] hid: simplify an index check in hid_lookup_collection Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290525880.28824.17.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox