* [PATCH 1/2] ASoC: wm8961 - clear WM8961_DACSLOPE bit for normal mode
@ 2010-11-24 2:20 Axel Lin
2010-11-24 2:21 ` [PATCH 2/2] ASoC: wm8961 - clear WM8961_MCLKDIV bit for freq <= 16500000 Axel Lin
2010-11-24 10:48 ` [PATCH 1/2] ASoC: wm8961 - clear WM8961_DACSLOPE bit for normal mode Liam Girdwood
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2010-11-24 2:20 UTC (permalink / raw)
To: linux-kernel; +Cc: Liam Girdwood, Mark Brown
DACSLOPE bit of Register 06h ADC and DAC Control 2:
0: Normal mode
1: Sloping stop-band mode
Thus in the case of normal mode, we should clear DACSLOPE bit.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/wm8961.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8961.c b/sound/soc/codecs/wm8961.c
index a0bb972..e4638e6 100644
--- a/sound/soc/codecs/wm8961.c
+++ b/sound/soc/codecs/wm8961.c
@@ -710,7 +710,7 @@ static int wm8961_hw_params(struct snd_pcm_substream *substream,
if (fs <= 24000)
reg |= WM8961_DACSLOPE;
else
- reg &= WM8961_DACSLOPE;
+ reg &= ~WM8961_DACSLOPE;
snd_soc_write(codec, WM8961_ADC_DAC_CONTROL_2, reg);
return 0;
--
1.7.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] ASoC: wm8961 - clear WM8961_MCLKDIV bit for freq <= 16500000
2010-11-24 2:20 [PATCH 1/2] ASoC: wm8961 - clear WM8961_DACSLOPE bit for normal mode Axel Lin
@ 2010-11-24 2:21 ` Axel Lin
2010-11-24 10:48 ` [PATCH 1/2] ASoC: wm8961 - clear WM8961_DACSLOPE bit for normal mode Liam Girdwood
1 sibling, 0 replies; 4+ messages in thread
From: Axel Lin @ 2010-11-24 2:21 UTC (permalink / raw)
To: linux-kernel; +Cc: Liam Girdwood, Mark Brown
MCLKDIV bit of Register 04h Clocking1:
0 : Divide by 1
1 : Divide by 2
Thus in the case of freq <= 16500000, we should clear MCLKDIV bit.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/wm8961.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8961.c b/sound/soc/codecs/wm8961.c
index e4638e6..6b22ef2 100644
--- a/sound/soc/codecs/wm8961.c
+++ b/sound/soc/codecs/wm8961.c
@@ -735,7 +735,7 @@ static int wm8961_set_sysclk(struct snd_soc_dai *dai, int clk_id,
freq /= 2;
} else {
dev_dbg(codec->dev, "Using MCLK/1 for %dHz MCLK\n", freq);
- reg &= WM8961_MCLKDIV;
+ reg &= ~WM8961_MCLKDIV;
}
snd_soc_write(codec, WM8961_CLOCKING1, reg);
--
1.7.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] ASoC: wm8961 - clear WM8961_DACSLOPE bit for normal mode
2010-11-24 2:20 [PATCH 1/2] ASoC: wm8961 - clear WM8961_DACSLOPE bit for normal mode Axel Lin
2010-11-24 2:21 ` [PATCH 2/2] ASoC: wm8961 - clear WM8961_MCLKDIV bit for freq <= 16500000 Axel Lin
@ 2010-11-24 10:48 ` Liam Girdwood
2010-11-24 11:27 ` Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Liam Girdwood @ 2010-11-24 10:48 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Mark Brown
On Wed, 2010-11-24 at 10:20 +0800, Axel Lin wrote:
> DACSLOPE bit of Register 06h ADC and DAC Control 2:
> 0: Normal mode
> 1: Sloping stop-band mode
>
> Thus in the case of normal mode, we should clear DACSLOPE bit.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Both
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-24 11:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-24 2:20 [PATCH 1/2] ASoC: wm8961 - clear WM8961_DACSLOPE bit for normal mode Axel Lin
2010-11-24 2:21 ` [PATCH 2/2] ASoC: wm8961 - clear WM8961_MCLKDIV bit for freq <= 16500000 Axel Lin
2010-11-24 10:48 ` [PATCH 1/2] ASoC: wm8961 - clear WM8961_DACSLOPE bit for normal mode Liam Girdwood
2010-11-24 11:27 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox