public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Milton Miller <miltonm@bga.com>
To: <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org
Cc: trivial@kernel.org, Steven Rostedt <rostedt@goodmis.org>,
	Will Schmidt <will_schmidt@vnet.ibm.com>,
	Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: trivial: make comment about vs{n,cn,}printf more understandable
Date: Tue, 23 Nov 2010 21:04:04 -0600	[thread overview]
Message-ID: <1290567844_20137@mail4.comsite.net> (raw)
In-Reply-To: <1290528765-25057-1-git-send-email-u.kleine-koenig@pengutronix.de>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]

On Tue, 23 Nov 2010 at about 16:12:45 -0000, Uwe Kleine-König wrote:
> 
> "You probably want ... instead." sounds like a recommendation better
> not to use the v... functions.
> 

Which is true, if you dont' have a va_list its hard to get them.
But I do get your point.

>   * the @buf not including the trailing '\0'. If @size is <= 0 the function
>   * returns 0.
>   *
> - * Call this function if you are already dealing with a va_list.
> - * You probably want scnprintf() instead.
> + * If you're not already dealing with a va_list better use scnprintf().

That doesn't flow off my (mid-western usa) tounge.

How about
 * Call this function if you are already dealing with a va_list.
 * Otherwise you probably want to use scnprintf().

Alternatively,
 * If you're not already dealing with a va_list consider scnprintf().

Thanks,
milton

  reply	other threads:[~2010-11-24  3:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-23 16:12 [PATCH] trivial: make comment about vs{n,cn,}printf more understandable Uwe Kleine-König
2010-11-24  3:04 ` Milton Miller [this message]
2010-11-24  3:20   ` Steven Rostedt
2010-11-24 15:27     ` Will Schmidt
2010-11-24 19:10   ` [PATCH v2] " Uwe Kleine-König
2011-04-06 14:34     ` Uwe Kleine-König
2011-04-06 14:37       ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290567844_20137@mail4.comsite.net \
    --to=miltonm@bga.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox